Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] upload media to order #202

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[NEW] upload media to order #202

wants to merge 3 commits into from

Conversation

WLsupport
Copy link

No description provided.

aimeos
aimeos reviewed Aug 31, 2021
View reviewed changes
admin/jqadm/js/admin.js Outdated
Comment on lines 1137 to 1139
Vue.component('l-map', window.Vue2Leaflet.LMap);
Vue.component('l-marker', window.Vue2Leaflet.LMarker);
Vue.component('l-tile-layer', window.Vue2Leaflet.LTileLayer);
Vue.component('l-map', window.Vue2Leaflet?.LMap);
Vue.component('l-marker', window.Vue2Leaflet?.LMarker);
Vue.component('l-tile-layer', window.Vue2Leaflet?.LTileLayer);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't mix different things in one PR

aimeos
aimeos reviewed Aug 31, 2021
View reviewed changes
.gitignore Outdated
Comment on lines 5 to 7

.idea
vendor
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove that from your PR?

@aimeos
Copy link
Owner

aimeos commented Aug 31, 2021

Thank you for your PR!
We use tabs instead of spaces to indent lines. Can you please change the spaces to tabs?

@rowild
Copy link
Contributor

rowild commented Aug 31, 2021 •
edited
Loading

@WLsupport I keep seeing this argument. Wouldn't that be automatically be solved with an editorConfig file added to all of your repositories?

[**.{js,php,css,json}]
indent_style = space
indent_size = 2

https://editorconfig.org/

@aimeos
Copy link
Owner

aimeos commented Sep 1, 2021

@rowild If it works we are happy to add such a file :-)

@aimeos
Copy link
Owner

aimeos commented Sep 18, 2021

Please indent with one tab per indention instead of spaces

@aimeos aimeos mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimeos aimeos aimeos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WLsupport @aimeos @rowild