Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for random state passing #278

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

VadimsAhmers
Copy link
Collaborator

@VadimsAhmers VadimsAhmers commented Dec 10, 2024

This PR completes the work started in PR #269.
The goal is to sync changes from the repro branch with main, including additional fixes.

Changes

  1. Synchronized the repro branch with main using rebase.
    All changes from the repro branch were merged into one commit to simplify the history.
  2. Some minor updates in requirements.txt for compatibility with Python 3.10.

All tests were successfully run on Python 3.8, 3.9 and 3.10.

nicl-nno and others added 2 commits December 8, 2024 21:52
*Random seed pass

*Test move

*Fix

*Imp 2

*Code review fixes

*Mirror fix
@nicl-nno
Copy link
Collaborator

А вот эти правки специально пришлось убрать?

https://github.com/aimclub/GOLEM/pull/269/files#diff-1f87812e47ef7b23a646340370b8f700524fb1ac518fce5804e47cd5929b0211R182

@VadimsAhmers
Copy link
Collaborator Author

А вот эти правки специально пришлось убрать?

https://github.com/aimclub/GOLEM/pull/269/files#diff-1f87812e47ef7b23a646340370b8f700524fb1ac518fce5804e47cd5929b0211R182

Они уже были залиты в main: e2b88e9

@nicl-nno
Copy link
Collaborator

Тогда вливай. Mirror из-за форка сломался.

@VadimsAhmers VadimsAhmers merged commit 45215bf into aimclub:main Dec 10, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants