Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m4 timeseries benchmark #1277

Merged
merged 5 commits into from
Aug 26, 2024
Merged

m4 timeseries benchmark #1277

merged 5 commits into from
Aug 26, 2024

Conversation

Lopa10ko
Copy link
Collaborator

@Lopa10ko Lopa10ko commented Mar 22, 2024

This is a 🔦 documentation change.

  • Include a M4 benchmark table in the documentation (01f7ee3)
  • Run the latest FEDOT version with topo features on M4 in the pytsbe and update metrics in the benchmark table (80f172f)
  • Add Fedot.Industrial results (related pytsbe PR)
  • Update AMLB classification metrics (139bb07)

@Lopa10ko Lopa10ko self-assigned this Mar 22, 2024
Copy link

docu-mentor bot commented Mar 22, 2024

👋 Hi, I'm @docu-mentor, an LLM-powered GitHub app
powered by Anyscale Endpoints
that gives you actionable feedback on your writing.

Simply create a new comment in this PR that says:

@docu-mentor run

and I will start my analysis. I only look at what you changed
in this PR. If you only want me to look at specific files or folders,
you can specify them like this:

@docu-mentor run doc/ README.md

In this example, I'll have a look at all files contained in the "doc/"
folder and the file "README.md". All good? Let's get started!

Copy link
Contributor

github-actions bot commented Mar 22, 2024

All PEP8 errors has been fixed, thanks ❤️

Comment last updated at

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (b711ebe) to head (139bb07).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1277      +/-   ##
==========================================
+ Coverage   79.92%   80.16%   +0.23%     
==========================================
  Files         146      146              
  Lines       10049    10278     +229     
==========================================
+ Hits         8032     8239     +207     
- Misses       2017     2039      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lopa10ko Lopa10ko added the documentation Improvements or additions to documentation label Mar 22, 2024
@valer1435
Copy link
Collaborator

@RepoPilotAssistant /improve

@RepoPilotAssistant
Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Readability
Align table headers for better readability

The table headers for the intervals are not aligned properly, which can make the table
difficult to read. Aligning the headers will improve readability and consistency.

docs/source/benchmarks/forecasting.rst [68-72]

 +    +-------------+----------+--------+--------+--------+-----------+--------+---------+
-+    | Library     | Quantile |                   Intervals                             |
-+    +             +          +--------+--------+--------+-----------+--------+---------+
-+    |             |          | Daily  | Weekly | Montly | Quarterly | Yearly | Overall |
-+    +=============+==========+========+========+========+===========+========+=========+
++    | Library     | Quantile | Daily  | Weekly | Montly | Quarterly | Yearly | Overall |
++    +=============+==========+========+========+========+========+========+========+
 
Suggestion importance[1-10]: 7

Why:

7
Align the "Overall" column cells for consistency

The table cells for the "Overall" column are not aligned consistently. Aligning these
cells will improve the visual consistency of the table.

docs/source/benchmarks/forecasting.rst [73-77]

-+    |   LagLlama  |   10     | 1.457  | 3.258  | 5.303  | 5.713     | 11.665 |  2.64   |
-+    |             |   50     | 4.513  | 11.167 | 18.534 | 20.027    | 33.141 | 13.036  |
-+    |             |   90     | 13.123 | 28.268 | 62.091 | 48.793    | 73.565 | 48.056  |
++    |   LagLlama  |   10     | 1.457  | 3.258  | 5.303  | 5.713     | 11.665 |  2.64  |
++    |             |   50     | 4.513  | 11.167 | 18.534 | 20.027    | 33.141 | 13.036 |
++    |             |   90     | 13.123 | 28.268 | 62.091 | 48.793    | 73.565 | 48.056 |
 
Suggestion importance[1-10]: 7

Why:

7
Align the "Library" column cells for consistency

The table cells for the "Library" column are not aligned consistently. Aligning these
cells will improve the visual consistency of the table.

docs/source/benchmarks/forecasting.rst [73-85]

-+    |   LagLlama  |   10     | 1.457  | 3.258  | 5.303  | 5.713     | 11.665 |  2.64   |
-+    |    NBEATS   |   10     | 0.732  | 1.021  | 1.173  | 1.818     | 3.038  | 1.036   |
-+    |   TimeGPT   |   10     | 1.687  | 1.272  | 1.134  | 2.459     | 4.179  | 1.536   |
++    | LagLlama    |   10     | 1.457  | 3.258  | 5.303  | 5.713     | 11.665 |  2.64  |
++    | NBEATS      |   10     | 0.732  | 1.021  | 1.173  | 1.818     | 3.038  | 1.036  |
++    | TimeGPT     |   10     | 1.687  | 1.272  | 1.134  | 2.459     | 4.179  | 1.536  |
 
Suggestion importance[1-10]: 7

Why:

7
Accuracy
Correct a misspelled word in the table header

The word "Montly" in the table header is misspelled. It should be corrected to "Monthly"
for accuracy and consistency.

docs/source/benchmarks/forecasting.rst [71]

-+    |             |          | Daily  | Weekly | Montly | Quarterly | Yearly | Overall |
++    |             |          | Daily  | Weekly | Monthly | Quarterly | Yearly | Overall |
 
Suggestion importance[1-10]: 7

Why:

7

@Lopa10ko Lopa10ko marked this pull request as ready for review August 26, 2024 05:01
Copy link
Collaborator

@DRMPN DRMPN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lopa10ko Lopa10ko merged commit b8740e3 into master Aug 26, 2024
6 checks passed
@Lopa10ko Lopa10ko deleted the m4-ts-benchmark branch August 26, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants