fix: Apply scale parameter within exp
in MultiScaleKernel
#40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that there is a typo in the implementation of
MultiScaleKernel
. Namely, @pjhartout and I would expect that the scale parameterself.sigma
should be applied before exponentiation in these two lines:pytorch-topological/torch_topological/nn/multi_scale_kernel.py
Line 134 in aba1474
pytorch-topological/torch_topological/nn/multi_scale_kernel.py
Line 135 in aba1474
For reference, consider equation 10 in https://arxiv.org/pdf/1412.6821.
In the current implementation,
self.sigma
only acts as a multiplicative factor on the kernel and thereby does not meaningfully change its behavior.This PR fixes the two lines above. The tests are passing locally for me.