Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scan): remove unused dependencies #193

Merged
merged 2 commits into from
Jan 18, 2025

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jan 17, 2025

Removes unused dependencies from the scan package:

  • @babel/generator - not used directly, already pulled in via @babel/core
  • @clack/core - not used directly, already pulled in via @clack/prompts
  • estree-walker - not used
  • tsx - not used

At the root of the monorepo:

  • @vercel/style-guide - doesn't seem to be referenced anywhere

Also changes a couple of FS paths to use __dirname in case tsup is ever run from another cwd.

This should drop a big chunk of the install size, re #178. Specifically since we drop tsx which is ~400KB.

Removes unused dependencies from the `scan` package:

- `@babel/generator` - not used
- `@clack/core` - not used directly, already pulled in via
  `@clack/prompts`
- `estree-walker` - not used
- `tsx` - not used

At the root of the monorepo:

- `@vercel/style-guide` - doesn't seem to be referenced anywhere

Also changes a couple of FS paths to use `__dirname` in case `tsup` is
ever run from another `cwd`.

This should drop a big chunk of the install size, re aidenybai#178. Specifically
since we drop `tsx` which is ~400KB.
Copy link

vercel bot commented Jan 17, 2025

@43081j is attempting to deploy a commit to the Million Team on Vercel.

A member of the Team first needs to authorize it.

@RobPruzan RobPruzan self-requested a review January 18, 2025 02:56
Copy link
Collaborator

@RobPruzan RobPruzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, going to rebase and resolve conflicts for you so we can get this merged

@RobPruzan RobPruzan merged commit 9f9dbe1 into aidenybai:main Jan 18, 2025
1 check failed
@43081j 43081j deleted the dependency-muncher branch January 18, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants