Merge pull request #64 from leoancap/syncMethod

add syncMethod prop to charts
ahrefs · Jan 13, 2025 · 2ff8805 · 2ff8805
2 parents 7b02a74 + 46e9aa5
commit 2ff8805
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 6 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,7 @@
+## 5.0.4
+
+- add `syncMethod` prop to `LineChart`, `AreaChart`, `BarChart`, `ComposedChart`
+
 ## 5.0.3
 
 - fix tick props in `XAxis`, `YAxis` and `ZAxis`
@@ -12,8 +16,8 @@
 
 ## 5.0.0
 
-- *[breaking]* improve bindings for XYZ axes, Treemap, Pie and Cell components [#59](https://github.com/ahrefs/melange-recharts/pull/59)
-- *[breaking]* remove `TooltipCursor` module [#60](https://github.com/ahrefs/melange-recharts/pull/60)
+- _[breaking]_ improve bindings for XYZ axes, Treemap, Pie and Cell components [#59](https://github.com/ahrefs/melange-recharts/pull/59)
+- _[breaking]_ remove `TooltipCursor` module [#60](https://github.com/ahrefs/melange-recharts/pull/60)
 
 ## 4.0.7 (2024-11-23)
 
@@ -104,10 +108,10 @@
 
 ## 1.0.2 (2021-05-19)
 
--  Bump url-parse from 1.4.7 to 1.5.1 in /examples (#40)
--  Bump lodash from 4.17.19 to 4.17.21 in /examples (#41)
--  Bump elliptic from 6.5.3 to 6.5.4 in /examples (#36)
--  Bump y18n from 4.0.0 to 4.0.1 in /examples (#37)
+- Bump url-parse from 1.4.7 to 1.5.1 in /examples (#40)
+- Bump lodash from 4.17.19 to 4.17.21 in /examples (#41)
+- Bump elliptic from 6.5.3 to 6.5.4 in /examples (#36)
+- Bump y18n from 4.0.0 to 4.0.1 in /examples (#37)
 
 ## 1.0.1 (2021-01-09)
 

diff --git a/src/AreaChart.re b/src/AreaChart.re
@@ -19,6 +19,7 @@ external make:
     ~onMouseMove: (Js.Nullable.t(Js.t({..})), React.Event.Mouse.t) => unit=?,
     ~stackOffset: stackOffset=?,
     ~syncId: string=?,
+    ~syncMethod: syncMethod=?,
     ~width: int=?,
     ~children: React.element
   ) =>

diff --git a/src/BarChart.re b/src/BarChart.re
@@ -23,6 +23,7 @@ external make:
     ~reverseStackOrder: bool=?,
     ~stackOffset: stackOffset=?,
     ~syncId: string=?,
+    ~syncMethod: syncMethod=?,
     ~width: int=?,
     ~children: React.element
   ) =>

diff --git a/src/ComposedChart.re b/src/ComposedChart.re
@@ -22,6 +22,7 @@ external make:
     ~reverseStackOrder: bool=?,
     ~stackOffset: stackOffset=?,
     ~syncId: string=?,
+    ~syncMethod: syncMethod=?,
     ~width: int=?,
     ~children: React.element
   ) =>

diff --git a/src/LineChart.re b/src/LineChart.re
@@ -17,6 +17,7 @@ external make:
     ~onMouseLeave: (Js.t({..}), React.Event.Mouse.t) => unit=?,
     ~onMouseMove: (Js.Nullable.t(Js.t({..})), React.Event.Mouse.t) => unit=?,
     ~syncId: string=?,
+    ~syncMethod: syncMethod=?,
     ~width: int=?,
     ~children: React.element
   ) =>

diff --git a/src/Utils.re b/src/Utils.re
@@ -50,6 +50,8 @@ type layout = [ | `horizontal | `vertical];
 
 type stackOffset = [ | `expand | `none | `wiggle | `silhouette | `sign];
 
+type syncMethod = [ | `index | `value];
+
 type margin = {
   .
   "top": int,