Improve tests #30
Open
Improve tests #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optimizations on the leading and trailing parts of the string invalidated the test for row size > minLengthThreshold
perf compares performance using benchstat between the last commit and uncommitted code
|
Great to see you again Paul. Could you please rebase with the latest master? I just merged @hanzei's changes. |
optimizations on the leading and trailing parts of the string invalidated the test for row size > minLengthThreshold
perf compares performance using benchstat between the last commit and uncommitted code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen that @hanzei has already submitted a PR for fuzzing, but the tests could probably be improved. I worked on the tests and benchmarks some time ago, but i didn't finish them. I have just had another idea this morning so i can now push this PR ;-)