Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the get_gateway and get_integration #110

Closed
wants to merge 1 commit into from

Conversation

nooperpudd
Copy link

change the gateway and integration find the gateway and integration
find the modules.

change the gateway and integration find the gateway and integration
find the modules.
@tuxcanfly
Copy link
Member

I can allow this for more flexibility in naming the gateway/integration classes, although I'm not convinced it is really necessary. When you're writing a custom gateway, you control the class name so you might as well name it as documented i.e like MyCustomGateway. Is there some case where you cannot name a class as like that?

Also, highly unlikely but if someone has another Gateway at the end of a module, this upgrade will pick up the last gateway class, so it risks backward compatibility.

@nooperpudd
Copy link
Author

@tuxcanfly Fine.

@nooperpudd nooperpudd closed this Jul 23, 2014
@tuxcanfly
Copy link
Member

@nooperpudd Thanks for reporting the issue, I'm thinking this should be fixed by removing the magic and simplifying the backend loading logic. See #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants