This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
generated from agilepathway/agilepathway-template
-
Notifications
You must be signed in to change notification settings - Fork 1
Specify internal employee project visibility #29
Open
johnboyes
wants to merge
6
commits into
master
Choose a base branch
from
project-visibility
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aemulus
approved these changes
Mar 14, 2021
aemulus
approved these changes
Mar 14, 2021
aemulus
reviewed
Mar 15, 2021
] | ||
) | ||
|
||
|
||
@step("An internal employee can see all projects") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there are a lot of layers in the python module and in the Jira logic over which we don't have control and if they change the simple checking of the same number of projects may lead to false positives. It might be safer to check if they can see the same number projects and if their project id's match:
@step("An internal employee can see all projects")
def an_internal_employee_can_see_all_projects():
internal_emp_proj = [_.raw['id'] for _ in Bot.internal_employee.projects()]
admin_emp_proj = [_.raw['id'] for _ in Bot.jira_admin.projects()]
assert len([_ for _ in admin_emp_proj if _ not in internal_emp_proj]) == 0
aemulus
approved these changes
Mar 15, 2021
aemulus
approved these changes
Mar 15, 2021
aemulus
approved these changes
Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.