Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add composer lyricist and genre tags #140

Closed
wants to merge 1 commit into from
Closed

Conversation

saecki
Copy link
Contributor

@saecki saecki commented Apr 30, 2021

Add at least some more metadata as requested in #92 and #134.

@saecki saecki marked this pull request as draft April 30, 2021 20:36
@pmphfm
Copy link
Contributor

pmphfm commented May 1, 2021

FWIW, I have a similar patch on a forked repo. I am using/running the fork for a while now. Both android app and web clients show/display that info. Here https://github.com/pmphfm/polaris/commits/master . The maintainer was not willing to add more fields so I had to fork. I haven't pushed the client changes.

(For me information about the song is more important than the artwork)

@saecki
Copy link
Contributor Author

saecki commented May 1, 2021

That looks nicer than my fork. Would you mind opening a PR in favor of this one?

@agersant
Copy link
Owner

agersant commented May 1, 2021

For context, I was originally not super interested in merging the changes because the fields will have to change again to support multi-value for semantic browsing. That is still true today, but I now realize that the work for semantic browsing is many months away so there is value in merging a PR adding fields in the mean time.

@saecki
Copy link
Contributor Author

saecki commented May 1, 2021

Closing in favor of #141.

@saecki saecki closed this May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants