Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganization of the code within the
Forms::submit
function to allow finer extensibility by other developers.All changes are backward compatible.
List of changes:
'forms.submit.email'
event to allow finer filtering of sent emails (eg. to avoid creating a specific template for each newly created form):&$response
parameter to'forms.submit.after
event to allow finer filtering of returned data (I don't really like phpmailer errors being sent directly to the browser)$this->app->renderer->file
with$this->app->view
(to allow access to app viewvars in email templates)modules/Forms/views/api/email.php
template (also useful for help people understand how to create their owns)Side notes
I just discovered the existence of this method PHPMailer::validateAddress($address, $patternselect), maybe this section could be further simplified?
cockpit/modules/Forms/bootstrap.php
Lines 271 to 280 in 722393b