Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cockpit + PHP7.2 + Nginx docker image #1274

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

gabskoro
Copy link

I created a docker image that:

  • Used PHP 7.2 + required modules (sqlite3, gd, mbstring, curl)
  • Uses Nginx
  • Downloads the application zip file from this repository

If you think this is nice to have, feel free to merge it or let me know if we should maybe move the text somewhere else rather then on the Readme page

Add info on how to start the app by using a docker image
@mpartipilo
Copy link

This is a strange pull request, just changing the readme to promote your own image.

Why not contribute the Dockerfile to this repo instead?

The current one uses Apache, another one replacing Apache for Nginx would be rather nice.

@gabskoro
Copy link
Author

C'mon guys, really... I didn't even one minute think about it as self-promotion. That's why I also wrote that we can move it somewhere else. Also if you guys have another idea I'm fine with it.

How would I contribute to the Dockerfile, maybe by adding a new one calling Dockerfile.nginx?

@mpartipilo
Copy link

No worries, it was just strange for me 😄

I would favor Dockerfile-nginx over Dockerfile.nginx, but that's a personal choice.

Let's see what other peers come up with.

@aheinze
Copy link
Member

aheinze commented Mar 17, 2020

@gabskoro thanks for the contribution! is there a reason why you're using php 7.2 and not eg 7.4?

@gabskoro
Copy link
Author

gabskoro commented Mar 17, 2020

@aheinze because there is no 7.3/7.4 version available through the debian repo, probably there is a way to add it, but I didn't spend any time looking for it. I also now see that they officially support for version 7.2 is till 30 November 2020, so probably would make sense to investigate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants