Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Candlestick perf 2 #2987

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Candlestick perf 2 #2987

merged 5 commits into from
Nov 15, 2024
+102 −69

Conversation

jacobp100
Copy link
Contributor

@jacobp100 jacobp100 commented Nov 14, 2024 •
edited
Loading

  • Ensures ordinal time axis' domain is always uniqued and sorted (forwards or backwards)
  • sortedTimestamps is always sorted forwards
  • timestamps is no longer needed

alantreadway
alantreadway approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@alantreadway alantreadway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alantreadway alantreadway merged commit 3ac4ba0 into latest Nov 15, 2024
24 checks passed
@alantreadway alantreadway deleted the financial-charts-perf-2 branch November 15, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alantreadway alantreadway alantreadway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobp100 @alantreadway