Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate with go-leak library and fix leaks #117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Integrate with go-leak library and fix leaks #117

wants to merge 3 commits into from

Conversation

isopropylcyanide
Copy link

@isopropylcyanide isopropylcyanide commented Aug 16, 2021 •
edited
Loading

Summary

PR Status Type Impact level
Ready Bug Medium

Description

  • Integrates with a Goleak detection library.
  • Fixed ~26 identified leaks in tests

@isopropylcyanide isopropylcyanide changed the title Integrate with go-leak library Integrate with go-leak library and fix leaks Aug 29, 2021
@avinash-fk
Copy link

Why is this not merged?

@isopropylcyanide
Copy link
Author

I guess I'm still awaiting a review here.

karmops
karmops approved these changes Jan 29, 2023
View reviewed changes
Copy link

@karmops karmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes many issues using go routines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karmops karmops karmops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isopropylcyanide @avinash-fk @karmops