Mail mover fix renames #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`:flags` need to be preserved when renaming files, but UIDs of the form `U=[0-9]+` should be removed. The current code fails to do that when a mail file has a UID but no flags. Change the code to nuke the non-flag part in any case.
Refactor so that the name generation becomes clearer, and before changing the dir generation. Change in behavour: returns a full path instead of a dir now in the rename==False case.
Currently, MailMover moves all mail to `/cur`. But everyone moving mail from `/new` to `/cur` is required to set up the maildir flags field in the name. Rather than setting up that field, preserve the maildir subdir part and let other clients change subdirs as necessary. After all, "moving" does not constitute "reading".
mjg
force-pushed
the
MailMover-fix-renames
branch
from
46dce1f
to
d96c0ac
Compare
GuillaumeSeren
approved these changes
Sep 18, 2019
|
As the mail mover as to be refactor and discussed again, Thank you for the patch @mjg 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here is a suggestion to fix #196.
A fix to #190 could go on top easily (although it is unrelated). In fact, there is currently a mix of "treating paths right" (
os.path...) and working with/by hand which could use some sanitizing.