Add tests for Kaffy.ResourceQuery #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonjoyce
force-pushed
the
add-tests-for-resource-query
branch
from
4326f24 to
88834e2
Compare
|
@brandonjoyce thank you for this PR. I think it's needed. I will check it out and merge it for next week's v0.11.0 release if all is good. |
|
Hi, Thanks for your contribution! Is this still required and works on the latest version? Gavin. |
|
We ended up not needing this in my particular project. If you want to close that would be fine. |
|
Ah, OK. I'll close this then. Thanks for your contribution anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some assumption in this PR that I don't know if you'll like or not such as adding Docker and ExMachina. Let me know if I'm way off and there's a better way.
This is in preparation for changes I need to make that relate to #278