Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3241] Throw exceptions when an MRT commit is called but transaction was already aborted and when an MRT abort is called but a transaction was already committed. #707

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Jan 3, 2025

Replace constants aerospike.MRT_COMMIT_ALREADY_ABORTED and aerospike.MRT_ABORT_ALREADY_COMMITTED with Aerospike exceptions TransactionAlreadyAborted and TransactionAlreadyCommitted, respectively

C client changes:

  • CLIENT-3231 Fix command buffer parsing code when a retry of a MRT verify or abort occurs.
  • CLIENT-3236 Pack CDT operations using the latest format.
  • CLIENT-3240 Initialize batch digests before keys in the batch MRT are added to the monitor record.
  • CLIENT-3242 Do not iterate through batch results to set in_doubt if the error is not in_doubt.

Extra changes:

  • Add missing type stub and documentation for TransactionFailed exception
  • [DOC-3201] Fix typo in TransactionFailed exception name

Regression testing

  • Build artifacts passes except for pipeline issues / noise
  • Valgrind shows no memory errors
  • massif looks fine

Doc changes
https://aerospike-python-client--707.org.readthedocs.build/en/707/aerospike.html#mrt-commit-status
https://aerospike-python-client--707.org.readthedocs.build/en/707/exception.html#aerospike.exception.TransactionFailed

@juliannguyen4 juliannguyen4 changed the title [CLIENT-3241] Throw exception when MRT commit called, but transaction was already aborted. [CLIENT-3241] Throw exceptions when an MRT commit is called but transaction was already aborted and when an MRT abort is called but a transaction was already committed. Jan 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (450d744) to head (13c8604).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #707      +/-   ##
==========================================
+ Coverage   81.05%   81.08%   +0.02%     
==========================================
  Files         102      102              
  Lines       15187    15187              
==========================================
+ Hits        12310    12314       +4     
+ Misses       2877     2873       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliannguyen4 juliannguyen4 marked this pull request as ready for review January 7, 2025 21:17
Copy link
Contributor

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@juliannguyen4 juliannguyen4 merged commit 8f58410 into dev Jan 7, 2025
144 of 191 checks passed
@juliannguyen4 juliannguyen4 deleted the CLIENT-3241 branch January 7, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants