Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLIENT-3157] Remove Python 3.8 support #689

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .github/workflows/build-wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -173,17 +173,6 @@ jobs:
# We need the last tag before the ref, so we can relabel the version if needed
fetch-depth: 0

- name: 'macOS arm64: Install experimental Python 3.8 macOS arm64 build'
# By default, cibuildwheel installs and uses Python 3.8 x86_64 to cross compile macOS arm64 wheels
# There is a bug that builds macOS x86_64 wheels instead, so we install this Python 3.8 native ARM build to ensure
# the wheel is compiled for macOS arm64
# https://cibuildwheel.pypa.io/en/stable/faq/#macos-building-cpython-38-wheels-on-arm64
if: ${{ matrix.python-tag == 'cp38' && inputs.platform-tag == 'macosx_arm64' }}
run: |
curl -o /tmp/Python38.pkg https://www.python.org/ftp/python/3.8.10/python-3.8.10-macos11.pkg
sudo installer -pkg /tmp/Python38.pkg -target /
sh "/Applications/Python 3.8/Install Certificates.command"

- name: 'Windows: Add msbuild to PATH'
if: ${{ inputs.platform-tag == 'win_amd64' }}
uses: microsoft/[email protected]
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/stage-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ jobs:
["ubuntu:22.04", 2, "linux/amd64", "3.10"],
["ubuntu:22.04", 2, "linux/arm64", "3.10"],
# Bookworm is Debian 12
["python:3.8-bookworm", 2, "linux/amd64", "3.8"],
["python:3.8-bookworm", 2, "linux/arm64", "3.8"],
["python:3.9-bookworm", 2, "linux/amd64", "3.9"],
["python:3.9-bookworm", 2, "linux/arm64", "3.9"],
["python:3.10-bookworm", 2, "linux/amd64", "3.10"],
Expand Down Expand Up @@ -152,7 +150,6 @@ jobs:
macos-14-large
]
python-version: [
"3.8",
"3.9",
"3.10",
"3.11",
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/test-server-rc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
matrix:
# Python versions to build wheels on
python: [
["3.8", "cp38"],
["3.9", "cp39"],
["3.10", "cp310"],
["3.11", "cp311"],
Expand Down Expand Up @@ -66,7 +65,6 @@ jobs:
fail-fast: false
matrix:
python: [
["3.8", "cp38"],
["3.9", "cp39"],
["3.10", "cp310"],
["3.11", "cp311"],
Expand Down Expand Up @@ -113,7 +111,6 @@ jobs:
strategy:
matrix:
python-version: [
["3.8", "cp38"],
["3.9", "cp39"],
["3.10", "cp310"],
["3.11", "cp311"],
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: PR tests

env:
LOWEST_SUPPORTED_PY_VERSION: '3.8'
LOWEST_SUPPORTED_PY_VERSION: '3.9'

# Trigger test workflow whenever:
# 1. A pull request is updated (e.g with new commits)
Expand Down Expand Up @@ -44,7 +44,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
py-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
py-version: ["3.9", "3.10", "3.11", "3.12"]
fail-fast: false

steps:
Expand Down Expand Up @@ -250,7 +250,6 @@ jobs:
strategy:
matrix:
py-version: [
"3.8",
"3.9",
"3.10",
"3.11",
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/valgrind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
build-manylinux-wheel:
uses: ./.github/workflows/build-wheels.yml
with:
python-tags: '["cp38"]'
python-tags: '["cp39"]'
platform-tag: manylinux_x86_64
sha-to-build-and-test: ${{ github.sha }}
secrets: inherit
Expand All @@ -40,12 +40,12 @@ jobs:

- uses: actions/setup-python@v2
with:
python-version: '3.8'
python-version: '3.9'
architecture: 'x64'

- uses: actions/download-artifact@v4
with:
name: cp38-manylinux_x86_64.build
name: cp39-manylinux_x86_64.build

- name: Install client
run: pip install ./*.whl
Expand Down
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Aerospike Python Client
Compatibility
-------------

The Python client for Aerospike works with Python 3.8 - 3.12 and supports the following OS'es:
The Python client for Aerospike works with Python 3.9 - 3.12 and supports the following OS'es:

* macOS 12 - 14
* CentOS 7 Linux
Expand Down
2 changes: 1 addition & 1 deletion doc/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def __getattr__(cls, name):
"sphinxcontrib.spelling"
]
napoleon_google_docstring = True
intersphinx_mapping = {"python": ("https://docs.python.org/3.8", None)}
intersphinx_mapping = {"python": ("https://docs.python.org/3", None)}

# Add any paths that contain templates here, relative to this directory.
templates_path = []
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ classifiers = [
"Operating System :: POSIX :: Linux",
"Operating System :: MacOS :: MacOS X",
"Operating System :: Microsoft :: Windows",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
Loading