[CLIENT-3146] Add support for free threading mode in Python 3.13 #686
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #686 +/- ##
==========================================
- Coverage 80.89% 0.00% -80.90%
==========================================
Files 102 56 -46
Lines 15186 10580 -4606
==========================================
- Hits 12285 0 -12285
- Misses 2901 10580 +7679 ☔ View full report in Codecov by Sentry. |
| client = aerospike.client(config) | ||
| _, _, bins = client.get(key) | ||
| nonlocal bin_value_sum | ||
| lock.acquire() |
There was a problem hiding this comment.
You shouldn't have an unnecessary lock here during the read_bin(). You can simply verify by doing something like the following:
-
in the test phase, have your base action be to update a record so the bin value changes from x to x + 1
-
in verification phase, sum the value of all bins you changed before and after the test. The difference should be the number of operations you submitted.
The key here is that you don't require locking during the submission of the updates
| @pytest.mark.usefixtures("as_connection") | ||
| class TestFreeThreading: | ||
| def test_unsafe(self): | ||
| key = ("test", "demo", 1) |
There was a problem hiding this comment.
Probably not a great idea to only use one key - you should generate a bunch of keys - the number of keys / number of operations will give you the basic collision rate.
| for worker in workers: | ||
| worker.join() | ||
|
|
||
| assert bin_value_sum == THREAD_COUNT * BIN_VALUE |
There was a problem hiding this comment.
I would also report out to a log the timing so you can calculate and report out basic throughput numbers. You can use this to sanity check to see if you get better numbers with a large transaction count, multiple threads running with and without GIL.
There was a problem hiding this comment.
Maybe it would be good to have both performance and data race testing?
This reverts commit dd38370.
juliannguyen4
force-pushed
the
CLIENT-3146-free-threading
branch
from
d440590 to
2b37036
Compare
todo:
notes
src/include/types.hhas global objsNot replacing PyDict_GetItem() because it will be removed in another PR
todo extra changes: