CLIENT-3256: Fixes to Pool<T> class, load balancer detection and Asyn…

…cOperateWrite (#142) * Disable load balancer address detection for localhost * Incorrect behavior of Pool<T>.PeekFirst * Listener is not copied when AsyncOperateWrite is cloned
aerospike · Jan 9, 2025 · a79c1ef · a79c1ef
1 parent 4f17f5c
commit a79c1ef
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/AerospikeClient/Async/AsyncOperateWrite.cs b/AerospikeClient/Async/AsyncOperateWrite.cs
@@ -35,6 +35,7 @@ public AsyncOperateWrite(AsyncCluster cluster, RecordListener listener, Key key,
 		public AsyncOperateWrite(AsyncOperateWrite other)
 			: base(other)
 		{
+			this.listener = other.listener;
 			this.args = other.args;
 		}
 

diff --git a/AerospikeClient/Cluster/NodeValidator.cs b/AerospikeClient/Cluster/NodeValidator.cs
@@ -230,7 +230,10 @@ private void ValidateAddress(Cluster cluster, IPAddress address, string tlsName,
 						// Disable load balancer detection for localhost.
 						detectLoadBalancer = false;
 					}
-
+				}
+
+				if (detectLoadBalancer)
+				{
 					// Seed may be load balancer with changing address. Determine real address.
 					addressCommand = (cluster.tlsPolicy != null) ?
 						cluster.useServicesAlternate ? "service-tls-alt" : "service-tls-std" :

diff --git a/AerospikeClient/Cluster/Pool.cs b/AerospikeClient/Cluster/Pool.cs
@@ -154,7 +154,7 @@ public T PeekFirst()
 					return default;
 				}
 
-				return items[head];
+				return items[head == 0 ? items.Length - 1 : head - 1];
 			}
 			finally
 			{
-Original file line number
+Diff line change
@@ Expand Up / @@ -154,7 +154,7 @@ public T PeekFirst() @@
     					return default;
     				}
-    				return items[head];
+    				return items[head == 0 ? items.Length - 1 : head - 1];
     			}
     			finally
     			{
@@ Expand Down @@