Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Commit

Permalink
Merge pull request #1106 from vania-pooh/master
Browse files Browse the repository at this point in the history
New safaridriver interaction fix
  • Loading branch information
vania-pooh authored May 21, 2021
2 parents 71c6537 + 1939bba commit e6523b6
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 1 addition & 3 deletions docs/faq.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,8 @@ When running Selenoid as Docker container video feature can be not working (beca

**Can't get VNC feature to work: Disconnected**

Please check the following:
Please check that you have `enableVNC = true` capability in your tests

. You have `enableVNC = true` capability in your tests
. You are using browser images with `vnc` in their name, e.g. `selenoid/vnc:firefox:58.0`.

**Seeing black screen with a cross in VNC window**

Expand Down
13 changes: 7 additions & 6 deletions docs/starting-selenoid-manually.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
. Create `config/browsers.json` configuration file with content:
+
.config/browsers.json
[source,javascript]
[source,json]
----
{
"firefox": {
"default": "57.0",
"versions": {
"57.0": {
"image": "selenoid/vnc:firefox_57.0",
"image": "selenoid/firefox:88.0",
"port": "4444",
"path": "/wd/hub"
}
Expand All @@ -31,7 +31,7 @@ NOTE: For Chrome and Opera images "path" is "/" instead of "/wd/hub"
+
. Pull browser Docker image:
+
`$ docker pull selenoid/vnc:firefox_57.0`.
`$ docker pull selenoid/firefox:88.0`.

=== Browser Images
We maintain a set of prebuilt Docker container images for different browsers including:
Expand All @@ -48,20 +48,21 @@ Feel free to create issues or request images for new versions.
====
. Complete list of browser images can be found in <<Browser Image information>>
. These images support all UTF-8 locales. This can be important if you want to save files using national alphabet symbols. You can enable your preferred locale in browsers configuration file by setting respective environment variables:
```
[source,json]
----
{
"chrome": {
"default": "64.0",
"versions": {
"64.0": {
"image": "selenoid/vnc:chrome_64.0",
"image": "selenoid/chrome:90.0",
//...
"env" : ["LANG=ru_RU.UTF-8", "LANGUAGE=ru:en", "LC_ALL=ru_RU.UTF-8"]
}
}
}
}
```
----
====

=== Start Selenoid
Expand Down
1 change: 1 addition & 0 deletions selenoid.go
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,7 @@ func proxy(w http.ResponseWriter, r *http.Request) {
}
}
r.URL.Host, r.URL.Path = sess.URL.Host, path.Clean(sess.URL.Path+r.URL.Path)
r.Host = "localhost"
return
}
r.URL.Path = paths.Error
Expand Down

0 comments on commit e6523b6

Please sign in to comment.