This repository has been archived by the owner on Dec 17, 2024. It is now read-only.
Fix audio for video recordings for chrome #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
misi
commented
Oct 24, 2023
misi
commented
- Use the default working and config dir ~/.config/pulse
- Add global pulse client.conf the cookie
* use the default working and config dir ~/.config/pulse
misi
changed the title
Closed
vania-pooh
suggested changes
Oct 25, 2023
static/chrome/Dockerfile
Outdated
| @@ -22,6 +22,8 @@ COPY entrypoint.sh / | |||
| RUN \ | |||
| chmod +x /usr/bin/chromedriver && \ | |||
| chown -R selenium:nogroup /etc/opt/chrome/policies/managed/ | |||
|
|
|||
| RUN echo "cookie-file = ~/.config/pulse/cookie" >> /etc/pulse/client.conf | |||
There was a problem hiding this comment.
Let's append this echo call to previous RUN section. Apply the same fix for all Dockerfiles. All the rest looks good.
vania-pooh
suggested changes
Oct 25, 2023
| @@ -8,5 +8,7 @@ COPY entrypoint.sh / | |||
|
|
|||
| USER selenium | |||
|
|
|||
| RUN echo "cookie-file = ~/.config/pulse/cookie" >> /etc/pulse/client.conf | |||
There was a problem hiding this comment.
Here you are creating config file as user selenium, whereas for chrome, opera and yandex - under root. Shouldn't this behavior be the same?
There was a problem hiding this comment.
Yes sorry, my bad. Great catch! Fixed it in 4349064. 🙏
vania-pooh
approved these changes
Oct 26, 2023
|
@misi squashed and merged. thank you for contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.