Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling the creation of namespaces defined in quotas #220

Closed
wants to merge 1 commit into from

Conversation

croemmich
Copy link

In our environment, namespaces are provisioned from information pulled from our IAM system. This causes conflicts with the moon2 chart which expects to be able to make the namespace referenced in the quota values, which will already exist.

This PR adds a createNamespace boolean value to each quota definition that allows for disabling the creation of the namespace. The value defaults to true to maintain backwards compatibility for users who do not set the value.

In the following example, the alpha namespace will NOT be created and the beta and gamma namespaces WILL be created:

quota:
  moon: null
  alpha-team:
    namespace: alpha
    createNamespace: false
  beta-team:
    namespace: beta
    createNamespace: true
  gamma-team:
    namespace: gamma

@vania-pooh
Copy link
Member

@aandryashin please take a look.

@vania-pooh
Copy link
Member

@croemmich this PR changes our default logic because createNamespace default value is false, so by default namespace will not be created. We'll implement this ourselves in #221.

@croemmich
Copy link
Author

Sounds good, thanks!

When I tested it, the default value was null rather than false so this worked as intended.

@vania-pooh
Copy link
Member

Implemented in #226.

@vania-pooh vania-pooh closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants