Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs version used in GitHub actions #38

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

xRuiAlves
Copy link
Contributor

@xRuiAlves xRuiAlves commented Apr 22, 2024

We are using github actions versions that, underlying, are using NodeJS 16 (which is mark for deprecation!).
We should bump their versions to the ones using NodeJS 20.

Does this change require an update to the documentation?

No.

Can this PR be safely merged to the target branch after approval?

Yes.

How has this been tested?

Relying on CI.

@xRuiAlves xRuiAlves requested a review from queimadus April 22, 2024 14:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8785438837 1

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.859%

Totals Coverage Status
Change from base Build 8357822424 1: 0.0%
Covered Lines: 710
Relevant Lines: 711

💛 - Coveralls

@xRuiAlves xRuiAlves self-assigned this Apr 22, 2024
Copy link
Contributor

@queimadus queimadus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@queimadus queimadus merged commit efd1a94 into master Apr 22, 2024
12 checks passed
@queimadus queimadus deleted the update/nodejs-version-used-in-github-actions branch April 22, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants