[sc-66697] Replace node-fetch with nodejs fetch #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients have reported that the SDK cannot be used in CommonJS projects. This is due to node-fetch@3 being an ESM only module.
With Node v18
With Node v20
There are workarounds suggested by the maintainers of node-fetch for use with CommonJS, however our use is minimal, therefore we can replace it with NodeJS's fetch which was made GA in v18.
Tested using https://github.com/adzerk/adzerk-management-sdk-integration-tests pointing to a local copy of the SDK.