Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support servers with subdirectory #1417

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

mikiher
Copy link
Contributor

@mikiher mikiher commented Dec 23, 2024

This adds support for connecting to servers with subdirectory, e.g. https://my.server.com/audiobookself.

This is the last step in preparing for subdirectory support, based on the proposed plan.

The required changes include:

  • Allow paths when specifying the server address in the Connect form
  • Fix this.player.src in AbsAudioPlayer.js (all other changes in this file are due to formatting)
  • Connect to the correct WebSocket path
  • Fix getLibraryItemCoverSrc and getLibraryItemCoverSrcById in globals.js

I tested this using the web client, as well as on my Android phone against a server running with RouterBasePath=/audiobookshelf (which should support both subdirectory and non-subdirectory access).

  • I connected using the standard non-subdirectory address, and made sure everything was working
  • I then connected using the subdirectory address, and made sure everything was working.

I did not test on iOS, as I don't have an IOS dev environement nor an iOS phone to test on.

@advplyr
Copy link
Owner

advplyr commented Dec 27, 2024

I tested this on Android/iOS/web including android auto. Works great, thanks!

@advplyr advplyr merged commit 817eaf1 into advplyr:master Dec 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants