Segfault on strings tensors with mistmatched dimensions, due to Go code
Moderate severity
GitHub Reviewed
Published
Aug 11, 2021
in
tensorflow/tensorflow
•
Updated Nov 13, 2024
Description
Published by the National Vulnerability Database
Aug 12, 2021
Reviewed
Aug 24, 2021
Published to the GitHub Advisory Database
Aug 25, 2021
Last updated
Nov 13, 2024
Impact
Under certain conditions, Go code can trigger a segfault in string deallocation.
For string tensors,
C.TF_TString_Dealloc
is called during garbage collection within a finalizer function. However, tensor structure isn't checked until encoding to avoid a performance penalty. The current method for dealloc assumes that encoding succeeded, but segfaults when a string tensor is garbage collected whose encoding failed (e.g., due to mismatched dimensions).To fix this, the call to set the finalizer function is deferred until
NewTensor
returns and, if encoding failed for a string tensor, deallocs are determined based on bytes written.Patches
We have patched the issue in GitHub commit 8721ba96e5760c229217b594f6d2ba332beedf22 (merging #50508).
The fix will be included in TensorFlow 2.6.0. We will also cherrypick this commit on TensorFlow 2.5.1, which is the other affected version.
For more information
Please consult our security guide for more information regarding the security model and how to contact us with issues and questions.
Attribution
This vulnerability has been reported externally via a fixing PR.
References