Clean up 1a6d2e9 #1153
Merged
Clean up 1a6d2e9 #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
pppd-accept-remote
branch
7 times, most recently
from
a30fa4e to
c01c9b1
Compare
Runtime option `pppd-accept-remote` will remain available at all time, but will now accept a boolean argument: * `--pppd-accept-remote=1`: invoke pppd with the `ipcp-accept-remote` option, which is required by pppd ≥ 2.5.0. * `--pppd-accept-remote=0`: invoke pppd without the `ipcp-accept-remote` option, which is required by pppd < 2.5.0. * `--pppd-accept-remote` is kept as a deprecated, undocumented synonym of `--pppd-accept-remote=1`. Build-time option `--enable-legacy-pppd` will change the default from `--pppd-accept-remote=1` to `--pppd-accept-remote=0`. This might be preferable on older platforms shipping pppd < 2.5.0, such as macOS.
DimitriPapadopoulos
force-pushed
the
pppd-accept-remote
branch
from
c01c9b1 to
cbf29a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime option
pppd-accept-remotewill remain available at all time, but will now accept a boolean argument:--pppd-accept-remote=1: invoke pppd with theipcp-accept-remoteoption, which is required by pppd ≥ 2.5.0.--pppd-accept-remote=0: invoke pppd without theipcp-accept-remoteoption, which is required by pppd < 2.5.0.--pppd-accept-remoteis kept as a deprecated, undocumented synonym of--pppd-accept-remote=1.Build-time option
--enable-legacy-pppdwill change the default from--pppd-accept-remote=1to--pppd-accept-remote=0. This might be preferable on older platforms shipping pppd < 2.5.0, such as macOS.