Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reverse flag for sorting by name #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rheber
Copy link

@rheber rheber commented Dec 11, 2016

#73

Copy link

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have merged and tested this change locally and confirmed it to work. Thanks!

@jfilak
Copy link

jfilak commented Jul 17, 2017

Could you please merged this pull request? I spent an hour debugging until I noticed that the flag --reverse works only for the time based sorting.

Well, IMHO multiplying by -1 is not the most obvious way how to do that but it sure works.

@jfilak
Copy link

jfilak commented Jul 18, 2017

@jbruchon Thank you very much. Since I already had the sources on my machine, I did my version of the patch:
return !ISFLAG(flags, F_REVERSE) ? strcmp(f1->d_name, f2->d_name) : strcmp(f2->d_name, f1->d_name);

built it, removed the correct files and dropped the local build :)

@FabioPedretti
Copy link

Duplicate of #102?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants