Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serving #55

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Serving #55

wants to merge 23 commits into from

Conversation

adoprox
Copy link
Owner

@adoprox adoprox commented Jan 17, 2024

No description provided.

	modified:   toxic_comments/data/make_dataset.py
	new file:   local_hosting/bert-base-uncased-vocab.txt
	new file:   local_hosting/dtm.py
	new file:   local_hosting/fastapi/app/__init__.py
	new file:   local_hosting/fastapi/app/main.py
	new file:   local_hosting/fastapi/fast.py
	new file:   local_hosting/fastapi/requirements.txt
	new file:   local_hosting/handler.py
	new file:   local_hosting/index_name.py
	new file:   local_hosting/index_to_name.json
	new file:   local_hosting/sample_text.txt
	new file:   local_hosting/setup_config_serve.json
	modified:   toxic_comments/models/config/default.yaml
    modified:   toxic_comments/predict_model.py
	modified:   toxic_comments/train_model.py
	deleted:    serving/bert-base-uncased-vocab.txt
	deleted:    serving/dtm.py
	deleted:    serving/handler.py
	deleted:    serving/index_name.py
	deleted:    serving/index_to_name.json
	deleted:    serving/sample_text.txt
	deleted:    serving/setup_config_serve.json
	deleted:    serving/dtm.py
	deleted:    serving/handler.py
	deleted:    serving/index_name.py
	deleted:    serving/index_to_name.json
	deleted:    serving/sample_text.txt
	deleted:    serving/setup_config_serve.json
	new file:   fastapi/__init__.py
	renamed:    local_hosting/fastapi/app/main.py -> fastapi/main.py
	renamed:    local_hosting/fastapi/requirements.txt -> fastapi/requirements.txt
	deleted:    local_hosting/fastapi/fast.py
	renamed:    local_hosting/fastapi/app/__init__.py -> slowapi/__init__.py
	new file:   slowapi/main.py
	new file:   slowapi/requirements.txt
	new file:   local_hosting/fastapi/main.py
	new file:   slowapi/ask.py
	new file:   slowapi/templates/1.html
	modified:   toxic_comments/predict_model.py
	modified:   toxic_comments/__init__.py
	modified:   toxic_comments/predict_model.py
	renamed:    slowapi/__init__.py -> toxic_comments/slowapi/__init__.py
	renamed:    slowapi/ask.py -> toxic_comments/slowapi/ask.py
	renamed:    slowapi/main.py -> toxic_comments/slowapi/main.py
	renamed:    slowapi/requirements.txt -> toxic_comments/slowapi/requirements.txt
	renamed:    slowapi/templates/1.html -> toxic_comments/slowapi/templates/1.html
	deleted:    fastapi/main.py
	deleted:    fastapi/requirements.txt
	modified:   toxic_comments/predict_model.py
	deleted:    fastapi/main.py
	deleted:    fastapi/requirements.txt
Copy link
Owner Author

@adoprox adoprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The local hosting folder and the slowapi folder are new for hosting the model locally and using flask app. The other new files are web.dockerfile and yaml for creating the container on gcp.
I trained the model using different config so maybe don't merge that.
In predict_model.py I added a comment and that's all, also no changes in make_dataset and init.py.
Hopefully should not break anything just adding features to locally host and host using gcp.

Copy link
Owner Author

@adoprox adoprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jajjaa deleted fastapi folder, messing with the ruff tests

Copy link
Owner Author

@adoprox adoprox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes made in train_model.py removed my function to save mode variables, should not mess with the main branch or break code.
removed fastapi unused imports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants