feat: add pagination to doc #155
Open
+133
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool !! On mobile, the two buttons can probably be stacked. Example on the nuxt doc: https://nuxt.com/docs/getting-started/configuration I think there are a few styling tweaks to be made, but I'll let @thetutlage talk about that first since he designed the website |
|
Oh it would look better like this, keeping it in mind, waiting for more info and i'll make the changes ! |
|
This is neat, great job @prisca-c! I agree with Julien, stacking the block on mobile seems the way to go. I am not sure if we should reverse the order on mobile; you are more likely to move forward than backward. |
|
I'll update it later and then i'll share how it'll looks ! |
|
Style Update 🎨 : 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
This is a PR to solve issue #34 .
I've added an edge global to handle the pagination called
getPaginationand called it insidedocs.edgewithin the component pagination.I'll share some screenshot of what it looks like.
Right now on desktop it looks like this :
When you hover a button it gets a little bit brighter.
The main "issue" here is when text takes a lot of place it looks really tight in mobile :
Eventually in mobile, text can be align left / right , i can edit it , here's how it looks like :
Tell me if you've got any suggestions ! 😄