generated from adobecom/milo-college
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-159445 - Remove thumbnail from authoring for change background in unity block #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
sanjayms01
approved these changes
Oct 16, 2024
This PR will be merged in coordination with authoring team. I have already synched with GWP and we are looking for a date next week to do the changes. |
robert-bogos
approved these changes
Oct 22, 2024
sanjayms01
pushed a commit
that referenced
this pull request
Oct 28, 2024
…n unity block (#134) - Remove thumbnail from authoring for change background in unity block - This update is done to fix an issue with html localization flow adobe/helix-html2md#555 Resolves: [MWPW-159445](https://jira.corp.adobe.com/browse/MWPW-159445) Test URLs: Before: https://main--cc--adobecom.hlx.page/drafts/ruchika/remove-background1?unitylibs=stage After: https://main--cc--adobecom.hlx.page/drafts/ruchika/remove-background1?unitylibs=loc errors.
Ruchika4
added a commit
that referenced
this pull request
Oct 29, 2024
#143) Stage to main sync PR (Stage PR (#134)) - Remove thumbnail from authoring for change background in unity block - This update is done to fix an issue with html localization flow adobe/helix-html2md#555 Resolves: [MWPW-159445](https://jira.corp.adobe.com/browse/MWPW-159445) Test URLs: Before: https://main--cc--adobecom.hlx.page/drafts/ruchika/remove-background1?unitylibs=main After: https://main--cc--adobecom.hlx.page/drafts/ruchika/remove-background1?unitylibs=stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-159445
Test URLs:
Before: https://main--cc--adobecom.hlx.page/drafts/ruchika/remove-background1?unitylibs=stage
After: https://main--cc--adobecom.hlx.page/drafts/ruchika/remove-background1?unitylibs=loc