Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: correct ci failures #5005

Merged
merged 3 commits into from
Jan 7, 2025
Merged

build: correct ci failures #5005

merged 3 commits into from
Jan 7, 2025

Conversation

castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Jan 6, 2025

Description

CI is failing on the rollover from 2024 - 2025 due to an automated copyright in a script. This is a short-term fix that just runs a clean install and commits the updated assets.

Motivation and context

Get CI passing on main.

How has this been tested?

  • git clean -dfX && yarn install: expect no changed files to show up: git status
  • Expect CI to pass

Types of changes

  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • [N/A] I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@castastrophe castastrophe requested a review from a team as a code owner January 6, 2025 20:09
Copy link
Contributor

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

github-actions bot commented Jan 6, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@castastrophe
Copy link
Contributor Author

Copy link

github-actions bot commented Jan 6, 2025

Tachometer results

Chrome

icons permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 628 kB 30.90ms - 31.55ms - faster ✔
1% - 4%
0.27ms - 1.15ms
branch 607 kB 31.65ms - 32.23ms slower ❌
1% - 4%
0.27ms - 1.15ms
-
Firefox

icons permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 628 kB 57.96ms - 63.64ms - unsure 🔍
-5% - +8%
-2.88ms - +4.52ms
branch 607 kB 57.61ms - 62.35ms unsure 🔍
-7% - +5%
-4.52ms - +2.88ms
-

Copy link

changeset-bot bot commented Jan 6, 2025

⚠️ No Changeset found

Latest commit: d371941

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Jan 6, 2025

Pull Request Test Coverage Report for Build 12639672674

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 98.209%

Totals Coverage Status
Change from base Build 12278981558: 0.003%
Covered Lines: 33006
Relevant Lines: 33430

💛 - Coveralls

Copy link

github-actions bot commented Jan 6, 2025

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 250.333 kB 236.457 kB 🏆 236.607 kB
Scripts 60.299 kB 53.896 kB 🏆 54.116 kB
Stylesheet 54.011 kB 48.001 kB 🏆 48.047 kB
Document 6.228 kB 5.471 kB 5.461 kB 🏆
Font 126.82 kB 126.738 kB 126.633 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@castastrophe castastrophe force-pushed the build-fix-ci-failure branch 4 times, most recently from 820206b to 2c26217 Compare January 6, 2025 21:00
@rubencarvalho rubencarvalho merged commit 6893bb3 into main Jan 7, 2025
24 of 25 checks passed
@rubencarvalho rubencarvalho deleted the build-fix-ci-failure branch January 7, 2025 10:48
@rubencarvalho rubencarvalho mentioned this pull request Jan 7, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants