Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: testing something #4989

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

rubencarvalho
Copy link
Collaborator

Description

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this
  • Test case 2

    1. Go here
    2. Do this
  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 92e7623

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.98 0.97 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 251.287 kB 236.832 kB 🏆 237.051 kB
Scripts 61.206 kB 54.269 kB 🏆 54.371 kB
Stylesheet 54.076 kB 48.117 kB 🏆 48.174 kB
Document 6.227 kB 5.46 kB 🏆 5.515 kB
Font 126.798 kB 126.634 kB 🏆 126.64 kB

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12282443963

Details

  • 7 of 19 (36.84%) changed or added relevant lines in 1 file are covered.
  • 257 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.8%) to 97.436%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/overlay/src/OverlayTrigger.ts 7 19 36.84%
Files with Coverage Reduction New Missed Lines %
packages/overlay/src/OverlayPopover.ts 2 84.91%
packages/overlay/src/OverlayDialog.ts 5 87.05%
packages/overlay/src/Overlay.ts 8 97.27%
packages/overlay/src/OverlayStack.ts 13 86.57%
packages/dialog/src/DialogBase.ts 16 87.02%
packages/overlay/src/HoverController.ts 24 87.56%
packages/overlay/src/OverlayTrigger.ts 30 80.65%
packages/overlay/src/LongpressController.ts 159 22.64%
Totals Coverage Status
Change from base Build 12278981558: -0.8%
Covered Lines: 32739
Relevant Lines: 33432

💛 - Coveralls

Copy link

Tachometer results

Chrome

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 54.64ms - 55.88ms - faster ✔
3% - 6%
1.52ms - 3.45ms
branch 716 kB 57.01ms - 58.48ms slower ❌
3% - 6%
1.52ms - 3.45ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 142.29ms - 145.56ms - faster ✔
3% - 6%
4.95ms - 9.68ms
branch 918 kB 149.54ms - 152.95ms slower ❌
3% - 7%
4.95ms - 9.68ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 71.07ms - 72.36ms - faster ✔
5% - 7%
3.55ms - 5.44ms
branch 875 kB 75.51ms - 76.91ms slower ❌
5% - 8%
3.55ms - 5.44ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 70.28ms - 72.30ms - faster ✔
4% - 7%
2.79ms - 5.68ms
branch 874 kB 74.49ms - 76.56ms slower ❌
4% - 8%
2.79ms - 5.68ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1874.53ms - 1877.52ms - unsure 🔍
-0% - +0%
-2.17ms - +2.47ms
branch 1.05 MB 1874.10ms - 1877.64ms unsure 🔍
-0% - +0%
-2.47ms - +2.17ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1879.54ms - 1882.77ms - unsure 🔍
-0% - +0%
-3.77ms - +1.35ms
branch 1.05 MB 1880.38ms - 1884.35ms unsure 🔍
-0% - +0%
-1.35ms - +3.77ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 978 kB 517.26ms - 524.63ms - faster ✔
2% - 4%
11.64ms - 21.19ms
branch 937 kB 534.32ms - 540.40ms slower ❌
2% - 4%
11.64ms - 21.19ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 42.30ms - 42.96ms - faster ✔
1% - 5%
0.42ms - 2.26ms
branch 959 kB 43.11ms - 44.84ms slower ❌
1% - 5%
0.42ms - 2.26ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 399.02ms - 408.68ms - faster ✔
0% - 3%
0.07ms - 12.48ms
branch 959 kB 406.23ms - 414.02ms slower ❌
0% - 3%
0.07ms - 12.48ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 53.76ms - 55.03ms - faster ✔
6% - 10%
3.62ms - 5.70ms
branch 899 kB 58.23ms - 59.89ms slower ❌
7% - 11%
3.62ms - 5.70ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 208.80ms - 212.94ms - faster ✔
1% - 4%
2.93ms - 7.69ms
branch 718 kB 215.01ms - 217.36ms slower ❌
1% - 4%
2.93ms - 7.69ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 982 kB 434.02ms - 443.11ms - slower ❌
0% - 3%
1.99ms - 11.97ms
branch 940 kB 429.52ms - 433.64ms faster ✔
0% - 3%
1.99ms - 11.97ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 26.28ms - 26.78ms - faster ✔
5% - 8%
1.42ms - 2.30ms
branch 1.02 MB 28.03ms - 28.76ms slower ❌
5% - 9%
1.42ms - 2.30ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 352.69ms - 356.57ms - faster ✔
3% - 5%
10.69ms - 17.39ms
branch 1.01 MB 365.94ms - 371.39ms slower ❌
3% - 5%
10.69ms - 17.39ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 44.78ms - 45.63ms - faster ✔
6% - 9%
2.89ms - 4.36ms
branch 806 kB 48.24ms - 49.43ms slower ❌
6% - 10%
2.89ms - 4.36ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 505.85ms - 512.73ms - faster ✔
4% - 5%
18.84ms - 29.48ms
branch 776 kB 529.39ms - 537.50ms slower ❌
4% - 6%
18.84ms - 29.48ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 107.98ms - 108.94ms - faster ✔
2% - 3%
1.82ms - 3.61ms
branch 775 kB 110.42ms - 111.93ms slower ❌
2% - 3%
1.82ms - 3.61ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 870 kB 35.96ms - 36.76ms - faster ✔
3% - 6%
1.13ms - 2.14ms
branch 805 kB 37.68ms - 38.30ms slower ❌
3% - 6%
1.13ms - 2.14ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 25.61ms - 26.04ms - faster ✔
7% - 10%
1.99ms - 2.74ms
branch 789 kB 27.88ms - 28.49ms slower ❌
8% - 11%
1.99ms - 2.74ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 53.63ms - 54.62ms - faster ✔
5% - 8%
3.05ms - 4.46ms
branch 912 kB 57.37ms - 58.38ms slower ❌
6% - 8%
3.05ms - 4.46ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 44.10ms - 45.12ms - faster ✔
6% - 9%
2.96ms - 4.57ms
branch 887 kB 47.75ms - 49.00ms slower ❌
7% - 10%
2.96ms - 4.57ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 62.97ms - 64.91ms - faster ✔
2% - 6%
1.58ms - 3.87ms
branch 763 kB 66.06ms - 67.27ms slower ❌
2% - 6%
1.58ms - 3.87ms
-
Firefox

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 739 kB 123.12ms - 131.20ms - unsure 🔍
-5% - +3%
-7.09ms - +3.77ms
branch 716 kB 125.19ms - 132.45ms unsure 🔍
-3% - +6%
-3.77ms - +7.09ms
-

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 959 kB 298.97ms - 303.07ms - faster ✔
16% - 18%
58.02ms - 67.22ms
branch 918 kB 359.52ms - 367.76ms slower ❌
19% - 22%
58.02ms - 67.22ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 161.38ms - 165.50ms - slower ❌
2% - 6%
2.74ms - 9.70ms
branch 875 kB 154.41ms - 160.03ms faster ✔
2% - 6%
2.74ms - 9.70ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 144.68ms - 150.76ms - faster ✔
0% - 6%
0.14ms - 9.46ms
branch 874 kB 148.99ms - 156.05ms slower ❌
0% - 6%
0.14ms - 9.46ms
-

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1897.62ms - 1906.50ms - faster ✔
0% - 1%
2.09ms - 13.91ms
branch 1.05 MB 1906.17ms - 1913.95ms slower ❌
0% - 1%
2.09ms - 13.91ms
-

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1909.17ms - 1913.95ms - unsure 🔍
-0% - +0%
-7.41ms - +0.73ms
branch 1.05 MB 1911.61ms - 1918.19ms unsure 🔍
-0% - +0%
-0.73ms - +7.41ms
-

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 978 kB 874.21ms - 882.67ms - faster ✔
2% - 5%
18.11ms - 46.45ms
branch 937 kB 897.20ms - 924.24ms slower ❌
2% - 5%
18.11ms - 46.45ms
-

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 67.23ms - 68.93ms - faster ✔
2% - 6%
1.64ms - 4.48ms
branch 959 kB 70.00ms - 72.28ms slower ❌
2% - 7%
1.64ms - 4.48ms
-

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 784.28ms - 810.04ms - slower ❌
6% - 10%
43.06ms - 70.62ms
branch 959 kB 735.43ms - 745.21ms faster ✔
6% - 9%
43.06ms - 70.62ms
-

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 117.09ms - 123.03ms - unsure 🔍
-7% - +0%
-8.41ms - +0.49ms
branch 899 kB 120.71ms - 127.33ms unsure 🔍
-0% - +7%
-0.49ms - +8.41ms
-

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 413.84ms - 427.60ms - faster ✔
0% - 4%
0.91ms - 18.41ms
branch 718 kB 424.97ms - 435.79ms slower ❌
0% - 4%
0.91ms - 18.41ms
-

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 715.69ms - 738.11ms - slower ❌
12% - 16%
74.23ms - 100.53ms
branch 1.02 MB 632.65ms - 646.39ms faster ✔
10% - 14%
74.23ms - 100.53ms
-

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 53.49ms - 54.35ms - faster ✔
4% - 6%
1.98ms - 3.46ms
branch 1.02 MB 56.04ms - 57.24ms slower ❌
4% - 6%
1.98ms - 3.46ms
-

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 718.31ms - 731.97ms - slower ❌
6% - 9%
41.31ms - 62.17ms
branch 1.01 MB 665.51ms - 681.29ms faster ✔
6% - 9%
41.31ms - 62.17ms
-

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 93.82ms - 96.10ms - faster ✔
7% - 11%
7.61ms - 11.87ms
branch 806 kB 102.90ms - 106.50ms slower ❌
8% - 13%
7.61ms - 11.87ms
-

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 1025.05ms - 1035.11ms - faster ✔
4% - 8%
46.27ms - 84.77ms
branch 776 kB 1077.02ms - 1114.18ms slower ❌
4% - 8%
46.27ms - 84.77ms
-

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 153.30ms - 161.18ms - unsure 🔍
-4% - +2%
-7.04ms - +2.92ms
branch 775 kB 156.25ms - 162.35ms unsure 🔍
-2% - +5%
-2.92ms - +7.04ms
-

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 88.16ms - 95.20ms - slower ❌
8% - 18%
6.31ms - 14.29ms
branch 912 kB 79.51ms - 83.25ms faster ✔
7% - 15%
6.31ms - 14.29ms
-

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 52.36ms - 53.72ms - faster ✔
2% - 4%
0.85ms - 2.39ms
branch 789 kB 54.30ms - 55.02ms slower ❌
2% - 5%
0.85ms - 2.39ms
-

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 157.44ms - 163.08ms - slower ❌
14% - 19%
19.35ms - 26.37ms
branch 912 kB 135.30ms - 139.50ms faster ✔
12% - 16%
19.35ms - 26.37ms
-

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 92.19ms - 93.41ms - faster ✔
22% - 28%
26.62ms - 36.62ms
branch 887 kB 119.46ms - 129.38ms slower ❌
29% - 39%
26.62ms - 36.62ms
-

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 789 kB 119.21ms - 125.95ms - unsure 🔍
-7% - +0%
-8.58ms - +0.46ms
branch 763 kB 123.62ms - 129.66ms unsure 🔍
-0% - +7%
-0.46ms - +8.58ms
-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants