feat(bundle): bundled css for dev/demos #3477
Open
+810
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b91e385 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
File metricsSummaryTotal size: 4.27 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsactionbutton
alertbanner
button
closebutton
colorwheel
dial
logicbutton
picker
popover
stepper
textfield
tooltip
typography
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
feat-create-css-bundle
branch
3 times, most recently
from
3181e52 to
95f3730
Compare
castastrophe
added
size-2 S
castastrophe
added
run_vrt
castastrophe
force-pushed
the
feat-create-css-bundle
branch
2 times, most recently
from
637f836 to
c431cb0
Compare
|
🚀 Deployed on https://pr-3477--spectrum-css.netlify.app |
castastrophe
force-pushed
the
feat-create-css-bundle
branch
5 times, most recently
from
b7360e9 to
69b9894
Compare
5t3ph
reviewed
Jan 6, 2025
5t3ph
requested changes
Jan 6, 2025
| @@ -17,6 +17,7 @@ | |||
| "build:docs": "nx build storybook --output-dir ../dist/", | |||
| "build:preview": "nx build storybook", | |||
| "builder": "nx run-many --target build report --projects", | |||
| "bundle": "nx build bundle", | |||
There was a problem hiding this comment.
The clean command didn't actually remove tools/bundle/dist, here's the output:
There was a problem hiding this comment.
It won't if it's cached but if I set clean commands to ignore the cache by default, they will run every build command every time, even if it should be cached. I could update the package.json clean command to skip cache though.
There was a problem hiding this comment.
I'm not sure it's a problem, just reporting since you had noted the command. Practically speaking, I'm not sure there's a reason to do this command adhoc so maybe it's not an issue worth spending time on?
castastrophe
force-pushed
the
feat-create-css-bundle
branch
from
b29b35b to
4bc2886
Compare
I'm seeing the same issue. The |
castastrophe
force-pushed
the
feat-create-css-bundle
branch
from
4bc2886 to
8f892bf
Compare
castastrophe
force-pushed
the
feat-create-css-bundle
branch
from
8f892bf to
b91e385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a bundle package for Spectrum CSS so that customers can leverage these in demos, documentation, or development.
This also updates the Storybook package to use the bundle instead of loading individual components for documentation page styling.
During bundling, I also found that the minifier was removing the stylelint-disable comments before the stylelint plugin was run so some of the logical-property "fixes" were supposed to be skipped. This PR forces the build to maintain the stylelint-disable comments thus increasing the bundle size a smidge.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
yarn clean:bundleshould remove the tools/bundle/dist directoryyarn bundleshould build the tools/bundle/dist output (expect to see index.css, index.min.css, and corresponding map files) (@5t3ph, @cdransf)yarn refresh:bundleshould update the tools/bundle/package.json to reflect the components/* directory accurately and the src/index.css to include the correct imports (@5t3ph, @cdransf)To-do list