feat(storybook)!: update chromatic add-on to latest version #3458
+274
−876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d0cda87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Deployed on https://pr-3458--spectrum-css.netlify.app |
File metricsSummaryTotal size: 4.27 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
feat-upgrade-chromatic-storybook-addon
branch
3 times, most recently
from
bc40fa2 to
0d1bab2
Compare
castastrophe
force-pushed
the
feat-upgrade-chromatic-storybook-addon
branch
from
0d1bab2 to
2ffe037
Compare
castastrophe
commented
Jan 2, 2025
| @@ -1,5 +1,3 @@ | |||
| {/* DocumentationTemplate.mdx */} | |||
There was a problem hiding this comment.
The build "test" command does not like these comments! Easier to just remove them than try to rework them.
castastrophe
commented
Jan 2, 2025
castastrophe
changed the title
castastrophe
added
dependencies
castastrophe
force-pushed
the
feat-upgrade-chromatic-storybook-addon
branch
from
2ffe037 to
7a869a3
Compare
| @@ -0,0 +1,12 @@ | |||
| --- | |||
| "@spectrum-css/preview": major | |||
There was a problem hiding this comment.
@castastrophe- with the config updates, additions to the env file, the dependency technically changed, I think major seems appropriate.
castastrophe
force-pushed
the
feat-upgrade-chromatic-storybook-addon
branch
2 times, most recently
from
9f398fd to
716a13a
Compare
BREAKING CHANGE: New chromatic configuration required for updated version support.
castastrophe
force-pushed
the
feat-upgrade-chromatic-storybook-addon
branch
from
716a13a to
d0cda87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chromatic moved away from
@chromaui/addon-visual-teststo the@chromatic-com/storybookpackage.This requires an update to the
chromatic.config.jsonsettings, removal of the generic argTypesRegex from the preview config, and a stricter import in the doc blocks (i.e.,fileName.jsnot justfileName).To support a successful build, our test command must maintain the autodocs and mdx syntax which requires we add this information to our build instructions in the .storybook/main.js file.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Expect to be able to run Storybook locally, connect to the Chromatic add-on in the component panel, and kick off a manual re-run of VRTs.
Screenshots
To-do list