feat!: 🎉 Spectrum 2 foundations #2786
Open
+16,516
−19,631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6938987 The changes in this PR will be included in the next version bump. This PR includes changesets to release 86 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
🚀 Deployed on https://pr-2786--spectrum-css.netlify.app |
File metricsSummaryTotal size: 3.13 MB* Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Detailsactionbutton
actiongroup
alertbanner
asset
assetcard
assetlist
avatar
button
buttongroup
calendar
card
checkbox
clearbutton
closebutton
coachindicator
coachmark
colorarea
colorhandle
colorloupe
colorslider
colorwheel
combobox
contextualhelp
datepicker
dial
dialog
divider
dropindicator
dropzone
fieldgroup
fieldlabel
floatingactionbutton
form
helptext
illustratedmessage
infieldbutton
link
logicbutton
menu
meter
miller
modal
opacitycheckerboard
page
pagination
picker
pickerbutton
popover
progressbar
progresscircle
radio
rating
search
sidenav
slider
splitview
statuslight
steplist
stepper
swatch
swatchgroup
switch
table
tabs
tag
textfield
thumbnail
toast
tooltip
tray
treeview
typography
underlay
well
tokens
* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
s2-foundations-redux
branch
3 times, most recently
from
3c12625 to
5f49e47
Compare
castastrophe
force-pushed
the
s2-foundations-redux
branch
10 times, most recently
from
88ff338 to
ad2cea7
Compare
castastrophe
added
the
skip_vrt
castastrophe
force-pushed
the
s2-foundations-redux
branch
11 times, most recently
from
07e741e to
e668259
Compare
castastrophe
force-pushed
the
s2-foundations-redux
branch
5 times, most recently
from
e9f4bbc to
99d17de
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @import "./spectrum.css"; | ||
|
|
||
| @container (--system: express) { | ||
| @container style(--system: express) { | ||
| .spectrum-Textfield { | ||
| --spectrum-textfield-border-color: var(--spectrum-gray-400); |
There was a problem hiding this comment.
Custom property "--spectrum-textfield-border-color" is not used or defined by the base file (themes/spectrum-two.css).
| @import "./spectrum.css"; | ||
|
|
||
| @container (--system: express) { | ||
| @container style(--system: express) { | ||
| .spectrum-Textfield { | ||
| --spectrum-textfield-border-color: var(--spectrum-gray-400); | ||
| --spectrum-textfield-border-color-hover: var(--spectrum-gray-500); |
There was a problem hiding this comment.
Custom property "--spectrum-textfield-border-color-hover" is not used or defined by the base file (themes/spectrum-two.css).
| DocsInternationalizedDetailVariants, | ||
| DocsInternationalizedHeadingBodyPairing, | ||
| DocsInternationalizedHeadingVariants, Template | ||
| DocsBodyVariants, |
| DocsInternationalizedHeadingBodyPairing, | ||
| DocsInternationalizedHeadingVariants, Template | ||
| DocsBodyVariants, | ||
| DocsCodeVariants, |
| DocsInternationalizedHeadingVariants, Template | ||
| DocsBodyVariants, | ||
| DocsCodeVariants, | ||
| DocsDetailVariants, |
| DocsBodyVariants, | ||
| DocsCodeVariants, | ||
| DocsDetailVariants, | ||
| DocsHeadingBodyPairing, |
| DocsCodeVariants, | ||
| DocsDetailVariants, | ||
| DocsHeadingBodyPairing, | ||
| DocsHeadingVariants, |
| DocsDetailVariants, | ||
| DocsHeadingBodyPairing, | ||
| DocsHeadingVariants, | ||
| DocsInternationalizedBodyVariants, |
| DocsHeadingBodyPairing, | ||
| DocsHeadingVariants, | ||
| DocsInternationalizedBodyVariants, | ||
| DocsInternationalizedCodeVariants, |
| DocsHeadingVariants, | ||
| DocsInternationalizedBodyVariants, | ||
| DocsInternationalizedCodeVariants, | ||
| DocsInternationalizedDetailVariants, |
| DocsInternationalizedBodyVariants, | ||
| DocsInternationalizedCodeVariants, | ||
| DocsInternationalizedDetailVariants, | ||
| DocsInternationalizedHeadingBodyPairing, |
| DocsInternationalizedCodeVariants, | ||
| DocsInternationalizedDetailVariants, | ||
| DocsInternationalizedHeadingBodyPairing, | ||
| DocsInternationalizedHeadingVariants, Template |
castastrophe
force-pushed
the
s2-foundations-redux
branch
19 times, most recently
from
3114d29 to
246fa4d
Compare
Expanding the existing themes system to support the new S2 mappings. --- Co-authored-by: castastrophe <[email protected]> Co-authored-by: Patrick Fulton <[email protected]> Co-authored-by: Cory Dransfeldt <[email protected]> Co-authored-by: Aziz Ramos <[email protected]> Co-authored-by: Josh Winn <[email protected]> Co-authored-by: Rise Erpelding <[email protected]> Co-authored-by: Marissa Huysentruyt <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: TarunAdobe <[email protected]> Co-authored-by: Dragan Eror<[email protected]>
* chore(menu): remove mod property and add fallback for spectrum classic
castastrophe
force-pushed
the
s2-foundations-redux
branch
from
246fa4d to
005b0c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request brings in the Spectrum 2 design foundations tokens to start the migration from our current design system to the latest. To accommodate these changes, this pull request makes a few updates to our build to facilitate more robust theme switching.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Remaining TODOs
Validation steps
Validating the compiled output
.spectrum--expressin thedist/themes/expressfile; this class should contain --system prefixed variables.spectrum--legacyin thedist/themes/legacy.cssfile; this class should contain --system prefixed variables.spectrumin thedist/themes/spectrum.cssfile; this class should contain --system prefixed variablesdist/index-theme.cssfile but no top-level classes (i.e., no.spectrumor.spectrum--legacy)Validating the compiled token output
tokens/componentsandtokens/dist/css/componentsfolder withbridge,express,legacy, andspectrumfolders insidetokens/components/bridge/actionbutton.cssfile to match thecomponents/actionbutton/dist/index-theme.cssoutputtokens/components/spectrum/actionbutton.cssfile to match thecomponents/actionbutton/dist/themes/spectrum.cssoutputtokens/components/legacy/actionbutton.cssfile to match thecomponents/actionbutton/dist/themes/legacy.cssoutputtokens/components/express/actionbutton.cssfile to match thecomponents/actionbutton/dist/themes/express.cssoutputRegression testing
Validate:
Screenshots
To-do list