Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model-viewer block for the Web Components docs page #459

Closed
wants to merge 8 commits into from

Conversation

bdelacretaz
Copy link
Contributor

@bdelacretaz bdelacretaz commented Jan 31, 2024

Add model-viewer block.

https://main--helix-website--adobe.aem.page/developer/web-components

vs

https://main--helix-website--bdelacretaz.hlx.page/developer/web-components

Description

This adds a model-viewer block for the upcoming Web Components docs page, along with the example 3D viewer component from https://modelviewer.dev/ and a <lazy-loader> Web Component to load all of that in the delayed phase.

Related Issue

#457

How Has This Been Tested?

Besides visual testing, the new code is covered by automated tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA (I'm an Adobe employee)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Jan 31, 2024

Page Scores Audits Google
/developer/web-components PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@dylandepass dylandepass self-requested a review February 22, 2024 01:03
Copy link
Member

@dylandepass dylandepass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

</div>
</div>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra </div>

Copy link
Contributor

@kptdobe kptdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the web component sample we use should be a project specific element, not something completely unrelated for which the code does not belong to the current project code.

@bdelacretaz
Copy link
Contributor Author

the web component sample we use should be a project specific element...

I chatted with kptdobe about this, the idea is to find a Web Component that is actually useful for this website, and can serve as an example while providing useful functionality for the website. I'll look for something suitable.

@bdelacretaz
Copy link
Contributor Author

I'll close this PR and create another one with a web component that does something useful for the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants