-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model-viewer block for the Web Components docs page #459
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
</div> | ||
</div> | ||
</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra </div>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the web component sample we use should be a project specific element, not something completely unrelated for which the code does not belong to the current project code.
I chatted with kptdobe about this, the idea is to find a Web Component that is actually useful for this website, and can serve as an example while providing useful functionality for the website. I'll look for something suitable. |
I'll close this PR and create another one with a web component that does something useful for the website. |
Add model-viewer block.
https://main--helix-website--adobe.aem.page/developer/web-components
vs
https://main--helix-website--bdelacretaz.hlx.page/developer/web-components
Description
This adds a
model-viewer
block for the upcoming Web Components docs page, along with the example 3D viewer component from https://modelviewer.dev/ and a<lazy-loader>
Web Component to load all of that in thedelayed
phase.Related Issue
#457
How Has This Been Tested?
Besides visual testing, the new code is covered by automated tests.
Types of changes
Checklist: