-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring task #6
Open
kzlomek
wants to merge
8
commits into
adblockplus:master
Choose a base branch
from
kzlomek:refactoring_task
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jul 19, 2018
-
Created Updater class for handling application updates and moved respective API from FilterEngine to Updater component. For now Updater class does not care about asynchronicity (if any) in JS files which are used for update checks logic. TODO: Move Updater class to dedicated .h and .cpp files. Abstracted jsSources from FilterEngine. Now every component (like FilterEngine and Updater) created by Platfrom gets EvaluateCallback and evaluates own JS files needed for internal logic. EvaluateCallback keeps track of evaluated files to avoid duplicated evaluations.
Configuration menu - View commit details
-
Copy full SHA for 46488a5 - Browse repository at this point
Copy the full SHA 46488a5View commit details -
WIP: FilterEngine and Updater JS api separation
Moved Updater class to dedicated header and source files. Created apiUpdater.js with a separate API for Updater component. Issues to fix: 1. Pass Prefs to Updater component - Now Updater sets just an empty Prefs object 2. Review content of apiUpdater.js and updaterJsFiles[] array - Check that all what's needed is set there and nothing is redundant - Does Updater component need to take care of asynchronicity in JS files? 3. Fix UpdateCheckTests - They are now passing just because FilterEngine object is created while those tests should just rely only on Updater object.
Configuration menu - View commit details
-
Copy full SHA for 540ca04 - Browse repository at this point
Copy the full SHA 540ca04View commit details
Commits on Jul 20, 2018
-
Added cpp methods for Prefs JS API. Removed not needed JS API. Added _isSubscriptionDownloadAllowed event callback to unblock downloads in JS code. Cleaned up UpdateCheckTest a bit removing FilterEngine because with the change above those tests don't require anymore FilterEnigne object to pass.
Configuration menu - View commit details
-
Copy full SHA for 5d21081 - Browse repository at this point
Copy the full SHA 5d21081View commit details
Commits on Jul 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7d6bdda - Browse repository at this point
Copy the full SHA 7d6bddaView commit details
Commits on Aug 4, 2018
-
Apart from changes in new code, this also withdraws changes in existing code not related with this feature.
Configuration menu - View commit details
-
Copy full SHA for 49f0171 - Browse repository at this point
Copy the full SHA 49f0171View commit details
Commits on Aug 8, 2018
-
Fixed thread safety and added more tests
Now creation of Updater is thread safe. Added synchronization for evaluatedJsSources set. Added more unit tests.
Configuration menu - View commit details
-
Copy full SHA for 511c949 - Browse repository at this point
Copy the full SHA 511c949View commit details
Commits on Aug 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 1ae9556 - Browse repository at this point
Copy the full SHA 1ae9556View commit details
Commits on Aug 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 956d620 - Browse repository at this point
Copy the full SHA 956d620View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.