Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring task #6

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Commits on Jul 19, 2018

  1. FilterEngine refactoring

    Created Updater class for handling application updates and moved
    respective API from FilterEngine to Updater component.
    For now Updater class does not care about asynchronicity (if any)
    in JS files which are used for update checks logic.
    TODO: Move Updater class to dedicated .h and .cpp files.
    
    Abstracted jsSources from FilterEngine. Now every component (like
    FilterEngine and Updater) created by Platfrom gets EvaluateCallback
    and evaluates own JS files needed for internal logic.
    
    EvaluateCallback keeps track of evaluated files to avoid duplicated
    evaluations.
    kzlomek committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    46488a5 View commit details
    Browse the repository at this point in the history
  2. WIP: FilterEngine and Updater JS api separation

    Moved Updater class to dedicated header and source files.
    
    Created apiUpdater.js with a separate API for Updater component.
    
    Issues to fix:
    
    1. Pass Prefs to Updater component
    - Now Updater sets just an empty Prefs object
    
    2. Review content of apiUpdater.js and updaterJsFiles[] array
    - Check that all what's needed is set there and nothing is redundant
    - Does Updater component need to take care of asynchronicity in JS
    files?
    
    3. Fix UpdateCheckTests
    - They are now passing just because FilterEngine object is created
    while those tests should just rely only on Updater object.
    kzlomek committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    540ca04 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2018

  1. Updates in Updater class

    Added cpp methods for Prefs JS API.
    Removed not needed JS API.
    Added _isSubscriptionDownloadAllowed event callback to unblock
    downloads in JS code.
    Cleaned up UpdateCheckTest a bit removing FilterEngine because
    with the change above those tests don't require anymore
    FilterEnigne object to pass.
    kzlomek committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    5d21081 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2018

  1. Code cleanup

    kzlomek committed Jul 22, 2018
    Configuration menu
    Copy the full SHA
    7d6bdda View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2018

  1. Addressed review comments

    Apart from changes in new code, this also withdraws
    changes in existing code not related with this feature.
    kzlomek committed Aug 4, 2018
    Configuration menu
    Copy the full SHA
    49f0171 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2018

  1. Fixed thread safety and added more tests

    Now creation of Updater is thread safe.
    Added synchronization for evaluatedJsSources set.
    Added more unit tests.
    kzlomek committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    511c949 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2018

  1. Configuration menu
    Copy the full SHA
    1ae9556 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2018

  1. Configuration menu
    Copy the full SHA
    956d620 View commit details
    Browse the repository at this point in the history