Fix: calculation leads to runtime error when switching to structurally different language (fixes #235)

[chris-steele]

#235

Fix

• calculation leads to runtime error when switching to structurally different language

[oliverfoster]

Why has the location not been changed when navigating to a new language?

https://github.com/adaptlearning/adapt-contrib-core/blob/4f04cc88b00570c0b950528d45adb6d60030e144/js/router.js#L364
https://github.com/adaptlearning/adapt-contrib-core/blob/4f04cc88b00570c0b950528d45adb6d60030e144/js/router.js#L204

[chris-steele]

Why has the location not been changed when navigating to a new language?

https://github.com/adaptlearning/adapt-contrib-core/blob/4f04cc88b00570c0b950528d45adb6d60030e144/js/router.js#L364 https://github.com/adaptlearning/adapt-contrib-core/blob/4f04cc88b00570c0b950528d45adb6d60030e144/js/router.js#L204

PLP is responding to a (bubbling) completion property change which occurs during the data load that changing language initiates - this occurs before adapt:start triggers routing in the start controller: https://github.com/adaptlearning/adapt-contrib-core/blob/master/js/startController.js#L93

[oliverfoster]

Should probably reset the location currentId on language change such that the first if statement returns early?

[chris-steele]

This PR will not be necessary if adaptlearning/adapt-contrib-core#567 is approved

[oliverfoster]

adaptlearning/adapt-contrib-core#567 is merged