Fix: locked attributes with conflicting default value (#591)

adaptlearning · Oct 15, 2024 · 6c58433 · 6c58433
1 parent b24f584
commit 6c58433
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/js/models/lockingModel.js b/js/models/lockingModel.js
@@ -32,11 +32,8 @@ export default class LockingModel extends Backbone.Model {
       const defaults = _.result(this, 'defaults');
       const isDefault = (defaults[attrName] !== undefined);
       const isInitialDefault = (isDefault && !this.changed);
-      if (isInitialDefault) {
-        this._lockedAttributes[attrName] = !defaults[attrName];
-      }
-
       const isSettingValueForSpecificPlugin = options?.pluginName;
+
       if (!isSettingValueForSpecificPlugin) {
         if (!isInitialDefault) {
           console.error('Must supply a pluginName to change a locked attribute');
@@ -65,7 +62,7 @@ export default class LockingModel extends Backbone.Model {
       }
     }
 
-    if (!Object.keys(newValues)) return this;
+    if (!Object.keys(newValues).length) return this;
 
     super.set(newValues, options);