-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Django 5.0 to test matrix (fixes #704) #710
Add Django 5.0 to test matrix (fixes #704) #710
Conversation
JeremyLWright
commented
Jul 12, 2024
- timezone information is now on by default, and serilizers are expecting zulu time.
- Replace manual timestamp truncation with datetime timespec set to milliseconds
908d0d7
to
1593499
Compare
Django 5.0 is not supported on python 3.8 and 3.9, Do you have a recommended method to exclude 5.0 for those python version CI runs? |
I don't think I've ever had to do this, but you might be able to check the Django version and Python version and skip the install/running the tests for the sessions that aren't supported? |
c4f1695
to
7d49763
Compare
Oh, interesting. I wonder if On the one hand, I liked being able to call Well, thanks for these changes -- I'll take a look at this more in depth soon and figure out what (if anything) I want to do about |
@JeremyLWright It looks like the actions error here: https://github.com/JeremyLWright/django-unicorn/actions/runs/10081907372/job/27874989875#step:6:12. I don't think |
7d49763
to
65cd887
Compare
@JeremyLWright Removing support for Python 3.8 and 3.9 greatly reduces the complications: JeremyLWright@3c25dd3. Django 5.0 has dropped support for those versions, so it doesn't seem completely unreasonable. What do you think? If I don't change the pyproject.toml to be >=3.10 I get this error :(. |
- timezone information is now on by default, and serilizers are expecting zulu time. - Replace manual timestamp truncation with datetime timespec set to milliseconds
558f7d6
to
8498fae
Compare
2c9d7dc
to
daaa70f
Compare
@all-contributors add JeremyLWright code |
I've put up a pull request to add @JeremyLWright! 🎉 |
It wasn't my call to make, @adamghill 😂. Dropping support does indeed make it easier. |