Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 5.0 to test matrix (fixes #704) #710

Merged

Conversation

JeremyLWright
Copy link
Contributor

  • timezone information is now on by default, and serilizers are expecting zulu time.
  • Replace manual timestamp truncation with datetime timespec set to milliseconds

@JeremyLWright JeremyLWright force-pushed the jeremy/#704-update-timezone-expectation branch from 908d0d7 to 1593499 Compare July 12, 2024 22:45
@JeremyLWright
Copy link
Contributor Author

JeremyLWright commented Jul 12, 2024

Django 5.0 is not supported on python 3.8 and 3.9, Do you have a recommended method to exclude 5.0 for those python version CI runs?

@adamghill
Copy link
Owner

Do you have a recommended method to exclude 5.0 for those python version CI runs?

I don't think I've ever had to do this, but you might be able to check the Django version and Python version and skip the install/running the tests for the sessions that aren't supported?

@JeremyLWright JeremyLWright force-pushed the jeremy/#704-update-timezone-expectation branch 5 times, most recently from c4f1695 to 7d49763 Compare July 24, 2024 18:17
@adamghill
Copy link
Owner

adamghill commented Jul 25, 2024

Oh, interesting. I wonder if nox is really needed anymore since everything is getting moved into GitHub actions at this point?

On the one hand, I liked being able to call nox locally, but I wonder if something like https://github.com/nektos/act would provide the same functionality?

Well, thanks for these changes -- I'll take a look at this more in depth soon and figure out what (if anything) I want to do about nox unless you have any thoughts about that.

@adamghill
Copy link
Owner

adamghill commented Jul 28, 2024

@JeremyLWright It looks like the actions error here: https://github.com/JeremyLWright/django-unicorn/actions/runs/10081907372/job/27874989875#step:6:12. I don't think poetry add python==${{ matrix.python-version }} can be used, but maybe poetry env use ${{ matrix.python-version }} would work?

@adamghill adamghill force-pushed the jeremy/#704-update-timezone-expectation branch from 7d49763 to 65cd887 Compare July 28, 2024 14:34
@adamghill
Copy link
Owner

adamghill commented Jul 28, 2024

@JeremyLWright Removing support for Python 3.8 and 3.9 greatly reduces the complications: JeremyLWright@3c25dd3. Django 5.0 has dropped support for those versions, so it doesn't seem completely unreasonable. What do you think?

If I don't change the pyproject.toml to be >=3.10 I get this error :(.

image

JeremyLWright and others added 6 commits July 28, 2024 16:10
- timezone information is now on by default, and serilizers are expecting zulu time.
- Replace manual timestamp truncation with datetime timespec set to milliseconds
@adamghill adamghill force-pushed the jeremy/#704-update-timezone-expectation branch from 558f7d6 to 8498fae Compare July 28, 2024 20:17
@adamghill adamghill force-pushed the jeremy/#704-update-timezone-expectation branch from 2c9d7dc to daaa70f Compare July 28, 2024 20:22
@adamghill adamghill merged commit 99ae323 into adamghill:main Jul 28, 2024
@adamghill
Copy link
Owner

@all-contributors add JeremyLWright code

Copy link
Contributor

@adamghill

I've put up a pull request to add @JeremyLWright! 🎉

@JeremyLWright
Copy link
Contributor Author

ed support for those versions, so it doesn't seem completely unreasonable.

It wasn't my call to make, @adamghill 😂. Dropping support does indeed make it easier.

@JeremyLWright JeremyLWright deleted the jeremy/#704-update-timezone-expectation branch July 29, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants