-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if there is a missing parent element #612
Conversation
This would be very helpful to me! |
@cyface How does this more explicit warning in the documentation with examples look? |
That is helpful! Again, not sure how to make painfully clear the difference between the component’s template and the outer template. 🤔 “There are typically two templates involved when using Unicorn. The component’s template, and the outer template where the application includes the component. If you need to render a component directly from a url rather than including it via template tag in an outer template, you can do that using Direct View.” ##Component Templates Outer TemplatesBlah blah unicorn tag |
Yeah, I think something like that could work. I'll continue to ruminate. |
this is super helpful |
…ew + template. Add warning about wrapper element. Explain convention for components.
After re-reading the docs a few times, I realized that it doesn't explicitly make it clear that components are a Python view + HTML template. So, I explicitly split out a new |
line 154 in I noticed that you went to the effort of removing a "just" statement in "Inheriting from |
Thanks for pointing that out @kevinbowen777. I've been trying to remove words like "just", "simple", "quick", etc. although I'm sure they are still more in there. 😄 I also just pushed some more changes mostly around rearranging the sidebar navigation to (hopefully) make things more clear. |
Typo in early part of the docs “forcing you to re-building your application” |
Thanks! 🚀 |
I'm going to merge this in, but any other feedback on doc changes would still be appreciated. 👍 |
Log a message if:
I should also update the docs to make it more clear, but a "wrapper" element is required for the DOM diffing algorithm to work properly. These checks should hopefully help catch invalid component templates earlier.