Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FeatherS2 board from Unexpected Maker #105

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

MakeItYourself85
Copy link

Created with Digital and Analog IO definitions
Included board image and boot-drive image

Still missing:

  • drag-drop.png
  • reset.png
  • usb.png

@brentru
Copy link
Member

brentru commented May 26, 2023

@MakeItYourself85 Feel free to ping me (@brentru) when you're ready for a review!

@MakeItYourself85
Copy link
Author

@brentru Ready for review

@brentru
Copy link
Member

brentru commented Aug 7, 2023

@MakeItYourself85 Have you started step 2 (building WipperSnapper) and step 3 (modifying wippersnapper) for this board as described here: https://learn.adafruit.com/how-to-add-a-new-board-to-wippersnapper/build-wippersnapper-with-platformio?

@MakeItYourself85
Copy link
Author

@brentru I was able to successfully build one of the existing projects (featheresp32s2) with platformio. However, the Unexpected Maker FeatherS2 board was not yet supported so I tried updating the platformio.ini file as follows:
image
but it looks like Wippersnapper_Boards.h needed some additional information:
image
I went into Wippersnapper_Boards.h to add the new board information there and that seems to have gotten me farther along in the build process:
image
Now I'm stuck on some issues in the network_interfaces/Wippersnapper_ESP32.h file which I'm going to need some help with:
image

@brentru
Copy link
Member

brentru commented Aug 8, 2023

Thanks for the detailed log! Could you copy and paste the platformio.ini entry below so I can try compiling on my end?

@MakeItYourself85
Copy link
Author

MakeItYourself85 commented Aug 8, 2023

; Unexpected Maker FeatherS2
[env:um_feathers2]
platform = espressif32
board = um_feathers2
build_flags = -DARDUINO_UNEXPECTEDMAKER_FEATHERS2
extra_scripts = pre:rename_usb_config.py
upload_port = COM4

@brentru : Sorry, I forgot to mention you on this message when I posted it last week

@brentru
Copy link
Member

brentru commented Aug 16, 2023

@MakeItYourself85 With two minor changes, I was able to build (untested as I don't have hardware for this:)

Environment    Status    Duration
-------------  --------  ------------
um_feathers2   SUCCESS   00:00:19.844

Here are the two changes I made which differed from your build:

Within WipperSnapper_FS.cpp, I added an inclusion for the FeatherS2:

    defined(ARDUINO_ADAFRUIT_QTPY_ESP32S3_N4R2) || \
    defined(ARDUINO_UNEXPECTEDMAKER_FEATHERS2)

In platformio.ini, I used extends to extend the common ESP32 environment:

; Unexpected Maker FeatherS2
[env:um_feathers2]
extends = common:esp32
board = um_feathers2
build_flags = -DARDUINO_UNEXPECTEDMAKER_FEATHERS2
extra_scripts = pre:rename_usb_config.py
upload_port = COM4

Please try applying these two changes and compiling them. It should be OK!

@MakeItYourself85
Copy link
Author

Yep, making those two changes worked. I was able to build and upload to the board successfully. Here's the output from the Upload process:

image

@MakeItYourself85
Copy link
Author

Seems like something broke when I was updating the naming conventions per https://learn.adafruit.com/how-to-add-a-new-board-to-wippersnapper/modifying-firmware. I'll keep working on it before I'm ready for another review.

@tyeth
Copy link
Contributor

tyeth commented May 25, 2024

@MakeItYourself85 it looks like your giving it another push, good work!
I work with Brent and I'm mostly around this long weekend (family visiting) so shout on the afafruit discord or here if you want a hand.

You'll need a matching branch in the Wippersnapper Arduino firmware repo too, mainly the boards file needs updating to have your entry too. Can't really test this until Wednesday when Brent returns, but I'll chat with Loren about how we can support in-development boards better on Tuesday. It's good timing as we plan to add some new in-development boards soon too!
For now if you're desperate you could set your board id in the code to return the afafruit S2 feather and then you'd see it compile and come online at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants