Added support for ADCs with other than 10 bit #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolution, by adding a optional paramter `adcBits` to constructor. In constructor member variable _adcMax is set to 2^adcBits-1. Subsequent calculations are now using this variable instead of constants 1023/1024 (which are only correct for 10bit ADCs).
This was referenced Oct 15, 2023
clang check barfed at trailing blank in comment - rather petty IMHO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for ADCs with other than 10 bir resolution, by adding a optional paramter
adcBitsto constructor.The constructor updates a member variable
_adcMaxto2^adcBits-1.Subsequent calculations are now using this variable instead of constants 1023/1024 (which are only correct for 10bit ADCs).
The addition of the optional parameter legacy code will not be affected by the change.