Prevent segfaults by implementing the rule of three #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This change includes the following:
calloc
, don't assume thatuint8_t
is 1 byte when you can just dosizeof(unit8_t)
alloc
ation andfree
ing into standalone functionsclass Adafruit_WS2801
to implement the rule of three [Wikipedia]There are no functional changes.
Motivation
I'm using arduino_ci to test a library that includes WS2801 as a dependency. I got this strange error:
This is caused because the unit test triggers a copy/assignment of the
Adafruit_WS2801
class; with no copy constructor explicitly provided, a shallow copy is made, which includes thepixels
pointer, meaning that 2 objects are now sharing memory. The trouble happens when the first of those objects drops out of scope and deallocates.This will probably never happen when run on Arduino, but for unit testing purposes it happens every time.
Testing
Example error from test here https://travis-ci.org/ianfixes/AcceleratedLED/builds/428427957#L185