Skip to content

Commit

Permalink
Remove global -Wno-stringop-overflow, -Wno-stringop-overread compiler…
Browse files Browse the repository at this point in the history
… options (facebookincubator#9432)

Summary:
This PR makes a change to remove the globally applied `-Wno-stringop-overflow` and `-Wno-stringop-overread` compiler options for GNU to warn for buffer overflows and undefined behaviour from reading past the end of the source buffer. PR facebookincubator#4618 originally disabled it.

Meant to address facebookincubator#9469

Pull Request resolved: facebookincubator#9432

Reviewed By: Yuhta

Differential Revision: D56193789

Pulled By: pedroerp

fbshipit-source-id: b25bd8df8bfba1fd7f5205e7e4976ac10455206d
  • Loading branch information
acvictor authored and facebook-github-bot committed Apr 16, 2024
1 parent 1bad4cf commit df0c499
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,7 @@ if("${ENABLE_ALL_WARNINGS}")
-Wno-unused-result \
-Wno-format-overflow \
-Wno-strict-aliasing \
-Wno-type-limits \
-Wno-stringop-overflow \
-Wno-stringop-overread")
-Wno-type-limits")
endif()

set(KNOWN_WARNINGS
Expand Down

0 comments on commit df0c499

Please sign in to comment.