🧹 optimise GoCardless bank sync to use fewer api calls #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
matt-fidd
changed the title
matt-fidd
changed the title
psybers
suggested changes
Aug 17, 2024
matt-fidd
force-pushed
the
optimise-gocardless-2
branch
3 times, most recently
from
9537442 to
290d0d7
Compare
psybers
approved these changes
Aug 17, 2024
matt-fidd
force-pushed
the
optimise-gocardless-2
branch
from
7362262 to
4ce9d38
Compare
MatissJanis
reviewed
Aug 22, 2024
matt-fidd
force-pushed
the
optimise-gocardless-2
branch
2 times, most recently
from
66f3a0d to
f7ba83b
Compare
Co-authored-by: Matiss Janis Aboltins <[email protected]>
matt-fidd
force-pushed
the
optimise-gocardless-2
branch
from
f7ba83b to
0cff3ed
Compare
MikesGlitch
approved these changes
Aug 25, 2024
MMichotte
pushed a commit
to MMichotte/actual-server
that referenced
this pull request
Sep 9, 2024
) * don't fetch balance from gocardless unless it's needed * release note * refactor into common function * Update src/app-gocardless/app-gocardless.js Co-authored-by: Matiss Janis Aboltins <[email protected]> --------- Co-authored-by: Matiss Janis Aboltins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on merge of #435
Part of #431
Complimentary to PR in actual: actualbudget/actual#3279
The balance fetched from gocardless is used to calculate the starting balance, which is only relevant when a completely blank account is synced. This change lays the groundwork in the server to allow the client side to be more selective in what it retrieves.