Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added PartialEq to Cors #486

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: added PartialEq to Cors #486

wants to merge 7 commits into from

Conversation

CommanderStorm
Copy link

@CommanderStorm CommanderStorm commented Dec 15, 2024 •
edited
Loading

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the nightly rustfmt (cargo +nightly fmt).

Overview

I have added impl PartialEq for Cors which should allow the testability improvements asked in #302

No breaking changes as far as I can tell

Closes #302

@CommanderStorm
Copy link
Author

(The CI fail seems unrelated as it also fails in #480)

@CommanderStorm CommanderStorm marked this pull request as ready for review December 16, 2024 00:04
@robjtede robjtede added A-cors Project: actix-cors B-semver-patch labels Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-cors Project: actix-cors B-semver-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow testing created Cors instance
2 participants
@CommanderStorm @robjtede