Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

Fix noproxy conventions #49

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewstuart
Copy link

No description provided.

@andrewstuart
Copy link
Author

Looks like we're not the first to notice this. This PR should address #40. 😄

@andrewstuart
Copy link
Author

@andymckay, any chance you could take a look at this? 🥺

@andrewstuart
Copy link
Author

Or @bryanmacfarlane ? Since Andy appears to be on vacation. 😁

Copy link

@0723Cu 0723Cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Help me

@andrewstuart
Copy link
Author

@andymckay, any chance we could get this reviewed? It's going to turn into a rather large problem for our team working behind corporate firewalls and proxies if we have to maintain a list of all hosts we need actions to communicate with.

@andrewstuart
Copy link
Author

Still hoping to see this merged. I can definitely say delays for something small but important like this are going to be a huge factor in what I push for in large enterprises I work for in the future. Especially when GitLab is actively writing blog posts about this, clearly doing some research: https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants